This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Fix InferStorage for sparse fallback in FullyConnected#11498
Merged
Conversation
Contributor
Author
Member
eric-haibin-lin
left a comment
There was a problem hiding this comment.
can we add test that will actually fail without this patch? (e.g rowsparse weight)
| DispatchMode wanted_mode; | ||
| #if 0 | ||
| bool dispatched = false; | ||
| // TODO(zhengda) let's disable MKLDNN for FullyConnected for now. |
Member
Contributor
There was a problem hiding this comment.
ideally we should enable it. i forgot the case that it fails. i don't think MKLDNN FC backward is much faster than our native implementation. so it's not very urgent.
@pengzhao-intel @TaoLv did you check if MKLDNN FC backward works in all cases?
Contributor
There was a problem hiding this comment.
We have enabled this in the #11301 and it passed all unit tests and coverage test in our local.
So, I think MKLDNN FC backward works fine.
Contributor
|
@haojin2 could you write a unit test? |
Contributor
Author
|
@zheng-da unit test added. |
Contributor
Author
zheng-da
approved these changes
Jul 11, 2018
12 tasks
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
* fix inferstorage for sparse in FullyConnected * test for the new infer storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#11448
Checklist
Essentials
Changes
Comments