Codestin Search App

access2rohit · 2018-07-06T18:43:24Z

Description

Added new operators "depth_to_space" and "space_to_depth" to mxnet

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Added new operators "depth_to_space" and "space_to_depth"

Comments

Ran Tests on CPU and GPU for both depth_to_space and space_to_depth operator 10000 times

access2rohit · 2018-07-06T18:44:00Z

@haojin2

haojin2 · 2018-07-12T23:32:52Z

@piiswrong @reminisce @anirudh2290 @eric-haibin-lin @rahul003 Please help with review when you have time, thanks!

eric-haibin-lin · 2018-07-13T20:37:08Z

 NNVM_REGISTER_OP(_backward_squeeze)
 .set_attr<FCompute>("FCompute<gpu>", UnaryOp::IdentityCompute<gpu>);

+NNVM_REGISTER_OP(depth_to_space)


Please also update https://github.com/apache/incubator-mxnet/blob/master/docs/api/python/ndarray/ndarray.md and docs/api/python/symbol/symbol.md when adding new ops

anirudh2290

Thank you for your contribution! Good work.

access2rohit · 2018-07-24T16:25:15Z

@rahul003 @reminisce @anirudh2290 @eric-haibin-lin @azai91

haojin2

In general LGTM but please introduce the randomized tests.

rahul003 · 2018-07-25T00:13:47Z

Agree with @haojin2 would be good to have some random tests

eric-haibin-lin

The link doesn't look right.
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-11587/14/api/python/ndarray/ndarray.html#array-rearrange-elements

The document is not very readable and the format seems off.
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-11587/14/api/python/ndarray/ndarray.html#mxnet.ndarray.depth_to_space

…n support

… added block_size check

…pes.

looks good now

apache#11587) * [MXNET-378] Adding depth_to_space and space_to_depth operator * fixed lint and windows CPU errors * compliance with C++ style guiide and address shortcomings in unittests * fixed documentation and nitpicky suggestions * added operator references in API docs and removed inplace optimization support * Added references in symbol.md and ndarray.md. Improved test cases and added block_size check * Fixing bugs in documentation. Tests now include tensors of random shapes.

access2rohit requested a review from szha as a code owner July 6, 2018 20:58

access2rohit force-pushed the master branch from c6438a9 to c5f7c29 Compare July 6, 2018 21:07

access2rohit changed the title ~~[MXNET-378] Adding depth_to_space and space_to_depth operator~~ [MXNET-378] Adding depth_to_space and space_to_depth operator(Updated) Jul 6, 2018

access2rohit force-pushed the master branch from c5f7c29 to 49a5247 Compare July 6, 2018 22:30

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 6, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 12, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

access2rohit force-pushed the master branch from 0bb84f5 to cc14190 Compare July 13, 2018 16:51

eric-haibin-lin reviewed Jul 13, 2018

View reviewed changes

access2rohit force-pushed the master branch from cc14190 to 968f767 Compare July 14, 2018 00:14

anirudh2290 suggested changes Jul 14, 2018

View reviewed changes

access2rohit force-pushed the master branch 2 times, most recently from ce29f04 to 0187ca1 Compare July 23, 2018 23:47

haojin2 reviewed Jul 24, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 24, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

haojin2 reviewed Jul 24, 2018

View reviewed changes

Comment thread tests/python/unittest/test_operator.py Outdated

anirudh2290 approved these changes Jul 24, 2018

View reviewed changes

haojin2 reviewed Jul 24, 2018

View reviewed changes

rahul003 reviewed Jul 25, 2018

View reviewed changes

Comment thread src/operator/tensor/matrix_op-inl.h Outdated

rahul003 approved these changes Jul 25, 2018

View reviewed changes

eric-haibin-lin previously requested changes Jul 25, 2018

View reviewed changes

Rohit Kumar Srivastava and others added 6 commits July 25, 2018 20:54

[MXNET-378] Adding depth_to_space and space_to_depth operator

f3389f5

fixed lint and windows CPU errors

0a48469

compliance with C++ style guiide and address shortcomings in unittests

21b19c0

fixed documentation and nitpicky suggestions

e803c95

added operator references in API docs and removed inplace optimizatio…

5187d2e

…n support

Added references in symbol.md and ndarray.md. Improved test cases and…

923f8a8

… added block_size check

access2rohit force-pushed the master branch from 0187ca1 to d678d23 Compare July 25, 2018 21:56

Fixing bugs in documentation. Tests now include tensors of random sha…

6879a50

…pes.

access2rohit force-pushed the master branch from d678d23 to 6879a50 Compare July 26, 2018 01:01

eric-haibin-lin merged commit c13ce5c into apache:master Jul 26, 2018

Conversation

access2rohit commented Jul 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Essentials

Changes

Comments

Uh oh!

access2rohit commented Jul 6, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

haojin2 commented Jul 12, 2018

Uh oh!

Uh oh!

Uh oh!

eric-haibin-lin Jul 13, 2018

Choose a reason for hiding this comment

Uh oh!

anirudh2290 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

access2rohit commented Jul 24, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

haojin2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rahul003 commented Jul 25, 2018

Uh oh!

eric-haibin-lin left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

access2rohit commented Jul 6, 2018 •

edited

Loading