Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-860] Reduce redundant copies, check for regressions with clang-tidy#12355

Merged
marcoabreu merged 2 commits into
apache:masterfrom
KellenSunderland:redun_copies
Sep 18, 2018
Merged

[MXNET-860] Reduce redundant copies, check for regressions with clang-tidy#12355
marcoabreu merged 2 commits into
apache:masterfrom
KellenSunderland:redun_copies

Conversation

@KellenSunderland
Copy link
Copy Markdown
Contributor

@KellenSunderland KellenSunderland commented Aug 25, 2018 •
edited
Loading

Description

Reduce redundant copies and add a check to clang-tidy to prevent future redundant copies. This change is a failure straightforward optimization that should not impact the correctness of the library.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Note: should only be applied after #12282

@KellenSunderland KellenSunderland force-pushed the redun_copies branch 2 times, most recently from 88104f0 to 4be7041 Compare September 2, 2018 13:27
@KellenSunderland KellenSunderland changed the title WIP - Reduce redundant copies. [MXNET-860] Reduce redundant copies, check for regressions with clang-tidy Sep 2, 2018
@KellenSunderland KellenSunderland mentioned this pull request Sep 2, 2018
Closed
7 tasks
@KellenSunderland
Copy link
Copy Markdown
Contributor Author

KellenSunderland commented Sep 5, 2018

@mxnet-label-bot can please add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Sep 5, 2018
@KellenSunderland KellenSunderland force-pushed the redun_copies branch 2 times, most recently from c622dc2 to 04e2705 Compare September 9, 2018 16:59
@marcoabreu marcoabreu merged commit 7168254 into apache:master Sep 18, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
@KellenSunderland @anirudh2290
[MXNET-860] Reduce redundant copies, check for regressions with clang…
74a75d5 
…-tidy (apache#12355)

* [MXNET-860] - Fix some unneeded copies

* [MXNET-860] - Add unnecessary copy check to clang-tidy
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

@marcoabreu marcoabreu Awaiting requested review from marcoabreu

1 more reviewer

@lebeg lebeg lebeg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KellenSunderland @lebeg @marcoabreu