This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-949] Module API to Gluon API tutorial#12542
Merged
ThomasDelteil merged 12 commits intoMar 21, 2019
Merged
Conversation
Ishitori
reviewed
Sep 14, 2018
Contributor
|
Thanks for your contribution @ThomasDelteil |
Ishitori
reviewed
Sep 14, 2018
Ishitori
reviewed
Sep 14, 2018
Ishitori
reviewed
Sep 14, 2018
|
@ThomasDelteil - Can you please rebase and resolve conflict? |
Contributor
|
@aaronmarkham for review @sandeep-krishnamurthy Please change the label to pr-awaiting-testing |
aaronmarkham
suggested changes
Oct 1, 2018
Contributor
aaronmarkham
left a comment
There was a problem hiding this comment.
I enjoyed this tutorial. This comparison was really needed. There are some minor grammatical/spelling issues and some clarity needs. I feel like each section should have a standard flow:
- overall intro of what the section does and very high level of how module/gluon differ
- code examples with intro
- compare / contrast detail + links to more examples
Member
|
@ThomasDelteil Can you please address review comments and resolve conflicting files? |
Member
|
ping @ThomasDelteil , any update on this PR? |
Contributor
Author
|
@roywei going to go through the comments this afternoon and push an update |
Member
anirudhacharya
left a comment
There was a problem hiding this comment.
should we add a note on how to visualize networks in - symbol graphs vs gluon blocks?
Contributor
|
@ThomasDelteil thanks for the contribution - can you please follow up on the comments? |
Contributor
Author
|
will re-open once I have time to address the comments, thanks all for the reviews 👍 |
thomelane
approved these changes
Mar 20, 2019
Contributor
thomelane
left a comment
There was a problem hiding this comment.
Much needed tutorial! Great job @ThomasDelteil. Only very minor suggestions.
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* Adding tutorial module to gluon * update test * update wording and typos * Update index.md * trigger build * update after review * update after review * update after review * adding license * Update module_to_gluon.md * trigger
ZhennanQin
pushed a commit
to ZhennanQin/incubator-mxnet
that referenced
this pull request
Apr 3, 2019
* Adding tutorial module to gluon * update test * update wording and typos * Update index.md * trigger build * update after review * update after review * update after review * adding license * Update module_to_gluon.md * trigger
nswamy
pushed a commit
that referenced
this pull request
Apr 5, 2019
* Adding tutorial module to gluon * update test * update wording and typos * Update index.md * trigger build * update after review * update after review * update after review * adding license * Update module_to_gluon.md * trigger
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* Adding tutorial module to gluon * update test * update wording and typos * Update index.md * trigger build * update after review * update after review * update after review * adding license * Update module_to_gluon.md * trigger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a tutorial to show the correspondence between Module and Gluon API to help users transition from the Module API to the Gluon one.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.