Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-12627] Fixed param coercion of clojure executor/forward#12630

Merged
gigasquid merged 1 commit into
apache:masterfrom
paroda:develop
Sep 21, 2018
Merged

[MXNET-12627] Fixed param coercion of clojure executor/forward#12630
gigasquid merged 1 commit into
apache:masterfrom
paroda:develop

Conversation

@paroda
Copy link
Copy Markdown
Contributor

@paroda paroda commented Sep 21, 2018

Description

Fixes an issue with clojure package (issue #12627)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • [x ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • [x ] Changes are complete (i.e. I finished coding on this PR)
  • [x ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

minor bugfix

@paroda paroda requested a review from gigasquid as a code owner September 21, 2018 09:59
@marcoabreu
Copy link
Copy Markdown
Contributor

Hey, thanks for your contribution! Would you mind adding a test please?

@gigasquid
Copy link
Copy Markdown
Member

Thanks @paroda for finding and fixing this bug. Looks good, just a couple small tweaks

Thanks again for you help. It is much appreciated 😸

@paroda
Copy link
Copy Markdown
Contributor Author

paroda commented Sep 21, 2018

sure, i'll update it and add the tests.

@paroda paroda closed this Sep 21, 2018
@paroda paroda reopened this Sep 21, 2018
@paroda paroda closed this Sep 21, 2018
@paroda
Copy link
Copy Markdown
Contributor Author

paroda commented Sep 21, 2018

oops! will reopen after the update

@marcoabreu
Copy link
Copy Markdown
Contributor

Feel free to just leave the PR open

@stu1130
Copy link
Copy Markdown
Contributor

stu1130 commented Sep 21, 2018

Thanks for making the clojure binding better! @paroda
@mxnet-label-bot[pr-work-in-progress]

@paroda
Copy link
Copy Markdown
Contributor Author

paroda commented Sep 21, 2018

updated with tests

Copy link
Copy Markdown
Member

@gigasquid gigasquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the improvement 😄

@gigasquid
Copy link
Copy Markdown
Member

When the CI tests pass. It's good to merge - Thanks again!

@gigasquid gigasquid merged commit 846bda4 into apache:master Sep 21, 2018
@paroda paroda deleted the develop branch September 22, 2018 07:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants