This repository was archived by the owner on Nov 17, 2023. It is now read-only.
ONNX import/export: Add missing tests, ONNX export: LogSoftMax#13654
Merged
Conversation
Contributor
Author
|
@mxnet-label-bot add [ONNX, pr-awaiting-review] |
Roshrini
suggested changes
Dec 14, 2018
b01106e to
94b22ca
Compare
Roshrini
approved these changes
Dec 14, 2018
Contributor
Author
|
@mxnet-label-bot update [ONNX, pr-awaiting-merge] |
Member
anirudhacharya
left a comment
There was a problem hiding this comment.
can you please explain why some of the tests have been removed?
Contributor
Author
|
@mxnet-label-bot update [ONNX, pr-work-in-progress] |
e155725 to
a1ccc7f
Compare
Contributor
Author
|
@mxnet-label-bot update [ONNX, pr-awaiting-review] |
Roshrini
reviewed
Dec 17, 2018
a2072ee to
8e81c64
Compare
Roshrini
approved these changes
Dec 19, 2018
8e81c64 to
9d7181a
Compare
sandeep-krishnamurthy
left a comment
There was a problem hiding this comment.
Thanks one minor comment.
9d7181a to
689d57e
Compare
689d57e to
81fb2f0
Compare
sandeep-krishnamurthy
approved these changes
Dec 28, 2018
sandeep-krishnamurthy
left a comment
There was a problem hiding this comment.
Great thanks for fixing other operator error messaging as well!
rondogency
pushed a commit
to rondogency/incubator-mxnet
that referenced
this pull request
Jan 9, 2019
…e#13654) * Logsoftmax, missing tests * Support multiple outputs in Gluon backendrep * Remove repeated unsqueeze test * Allow multiple output support
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
…e#13654) * Logsoftmax, missing tests * Support multiple outputs in Gluon backendrep * Remove repeated unsqueeze test * Allow multiple output support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding tests for operators that can currently be exported/imported from/to ONNX. Correcting the name of some tests. Added ONNX export of LogSoftMax too.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
ONNX export:
ONNX import:
Comments