Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

onnx export ops#13821

Merged
Roshrini merged 5 commits into
apache:masterfrom
Roshrini:export_ops
Jan 10, 2019
Merged

onnx export ops#13821
Roshrini merged 5 commits into
apache:masterfrom
Roshrini:export_ops

Conversation

@Roshrini
Copy link
Copy Markdown
Member

@Roshrini Roshrini commented Jan 9, 2019

Description

Adding operators - LogisticRegressionOutput, MakeLoss, BlockGrad, _rminus_scalar, r_div_scalar, identity
Fixes: #12682
#13641

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Roshrini Roshrini requested a review from szha as a code owner January 9, 2019 18:20
@Roshrini
Copy link
Copy Markdown
Member Author

Roshrini commented Jan 9, 2019

@mxnet-label-bot Add [ONNX, pr-awaiting-review]
Rebased and resolved conflicts here for this PR #13641
@vandanavk

@marcoabreu marcoabreu added ONNX pr-awaiting-review PR is waiting for code review labels Jan 9, 2019
@Roshrini Roshrini mentioned this pull request Jan 9, 2019
6 tasks
@Roshrini Roshrini merged commit d973ed4 into apache:master Jan 10, 2019
@Roshrini Roshrini deleted the export_ops branch January 10, 2019 19:57
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* onnx export ops

* retrigger ci

* retrigger ci

* fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ONNX pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No conversion function registered for op type BlockGrad yet

3 participants