Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[MXNet Scala] make dependencies required for compile time#13835

Merged
lanking520 merged 1 commit into
apache:masterfrom
lanking520:mavenpublish
Jan 11, 2019
Merged

[MXNet Scala] make dependencies required for compile time#13835
lanking520 merged 1 commit into
apache:masterfrom
lanking520:mavenpublish

Conversation

@lanking520
Copy link
Copy Markdown
Member

@lanking520 lanking520 commented Jan 10, 2019

Description

This is a fix for maven deploy. Make the depencies from runtime to compile time.
@piyushghai @frankfliu @gigasquid @andrewfayres @zachgk

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Copy link
Copy Markdown
Contributor

@frankfliu frankfliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@piyushghai piyushghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out with java-demo package that was breaking before this change.
Works now.
Thanks for the quick turnaround on this @lanking520

@lanking520 lanking520 merged commit 83b9165 into apache:master Jan 11, 2019
piyushghai pushed a commit to piyushghai/incubator-mxnet that referenced this pull request Feb 28, 2019
@lanking520 lanking520 deleted the mavenpublish branch March 11, 2019 22:29
lanking520 added a commit to lanking520/incubator-mxnet that referenced this pull request Apr 26, 2019
lanking520 added a commit to lanking520/incubator-mxnet that referenced this pull request Apr 26, 2019
lanking520 added a commit to lanking520/incubator-mxnet that referenced this pull request Apr 30, 2019
zachgk pushed a commit to zachgk/incubator-mxnet that referenced this pull request May 16, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants