This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Fix READMEs for examples#14179
Merged
Merged
Conversation
fixing examples and adding READMEs fixing examples and adding READMEs fixing examples and adding READMEs add missing files fixed some bugs in readmes fixed some bugs in readmes fixed some spelling mistakes update update
Member
|
sparse changes looks good to me |
ThomasDelteil
suggested changes
Feb 15, 2019
Contributor
ThomasDelteil
left a comment
There was a problem hiding this comment.
Awesome work, really help bringing the quality of our examples up. Minor comments and also we usually store images on dmlc/web-data to avoid bloating the mxnet repo with a lot of images.
|
|
||
| ## Data preperation | ||
|
|
||
| The MNIST dataset is available on Kaggle. Once train.csv is downloaded into the data/ folder, we can import into R. |
|
|
||
| For training: | ||
|
|
||
| - Arguments |
Contributor
There was a problem hiding this comment.
is there a train.py -h that can output a standardized helper output? If not maybe it would be good to add the comments you made straight in the code
Contributor
|
@NRauschmayr Thanks for the contribution! |
ankkhedia
reviewed
Feb 15, 2019
|
|
||
| 2. Download the dataset(train.zip, test.zip) required for this example from the location: | ||
| https://drive.google.com/drive/folders/0By0bAi7hOBAFUHVXd1JCN3MwTEU | ||
|
|
Contributor
There was a problem hiding this comment.
Should this dataset be added to the some mxnet related S3 bucket rather than a private google drive?
Contributor
Author
There was a problem hiding this comment.
I agree with you. We need to figure out what the license of the dataset is. I assume the original files are from here https://datahack.analyticsvidhya.com/contest/practice-problem-urban-sound-classification/#data_dictionary
And the Google drive link belongs to someone from analyticsvidhya, so maybe this link is the official source?
ChaiBapchya
approved these changes
Feb 18, 2019
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Mar 4, 2019
* fixing examples * fixing examples and adding READMEs fixing examples and adding READMEs fixing examples and adding READMEs fixing examples and adding READMEs add missing files fixed some bugs in readmes fixed some bugs in readmes fixed some spelling mistakes update update * removing images and fixing spelling mistakes * removing images and fixing spelling mistakes * updating links * Adding license header * empty commit * Add missing license headers * Adding changes requested by ChaiBapchya
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
* fixing examples * fixing examples and adding READMEs fixing examples and adding READMEs fixing examples and adding READMEs fixing examples and adding READMEs add missing files fixed some bugs in readmes fixed some bugs in readmes fixed some spelling mistakes update update * removing images and fixing spelling mistakes * removing images and fixing spelling mistakes * updating links * Adding license header * empty commit * Add missing license headers * Adding changes requested by ChaiBapchya
5 tasks
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* fixing examples * fixing examples and adding READMEs fixing examples and adding READMEs fixing examples and adding READMEs fixing examples and adding READMEs add missing files fixed some bugs in readmes fixed some bugs in readmes fixed some spelling mistakes update update * removing images and fixing spelling mistakes * removing images and fixing spelling mistakes * updating links * Adding license header * empty commit * Add missing license headers * Adding changes requested by ChaiBapchya
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some examples did not have READMEs or they were in the wrong folder. The README for CGAN-R example was taken from here http://dmlc.ml/rstats/2017/06/01/Generative-Adversarial-Network-in-R.html
I also fixed the mxnet_captcha.R example ( followup from https://discuss.mxnet.io/t/error-in-output-shape-output-names-dim-x-value-label-attempt-to-select-less-than-one-element-in-oneindex/3172/5)