Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Updated news.md with the latest mkldnn submodule version#14298

Merged
TaoLv merged 2 commits into
apache:masterfrom
piyushghai:news_fix
Mar 6, 2019
Merged

Updated news.md with the latest mkldnn submodule version#14298
TaoLv merged 2 commits into
apache:masterfrom
piyushghai:news_fix

Conversation

@piyushghai
Copy link
Copy Markdown
Contributor

Description

As title

@aaronmarkham Please review.

@wkcn wkcn requested a review from aaronmarkham March 2, 2019 01:45
@wkcn wkcn added the pr-awaiting-review PR is waiting for code review label Mar 2, 2019
@TaoLv
Copy link
Copy Markdown
Member

TaoLv commented Mar 2, 2019

@piyushghai Thank you for the change. Not sure if we also need have it on v1.4.x.

@pengzhao-intel
Copy link
Copy Markdown
Contributor

@piyushghai retrigger the CI?

Copy link
Copy Markdown
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

Copy link
Copy Markdown
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your update! LGTM : )

Current CI system has some problems, and we are working on it.

@piyushghai
Copy link
Copy Markdown
Contributor Author

@piyushghai retrigger the CI?

Done. @pengzhao-intel

@piyushghai
Copy link
Copy Markdown
Contributor Author

@piyushghai Thank you for the change. Not sure if we also need have it on v1.4.x.

@TaoLv No we don't need it on the v1.4.x branch. The master branch contains the latest news info on the previous release.

@wkcn wkcn added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Mar 5, 2019
@TaoLv
Copy link
Copy Markdown
Member

TaoLv commented Mar 6, 2019

Thank you. Merging now.

@TaoLv TaoLv merged commit f2497aa into apache:master Mar 6, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* Updated news.md with the latest mkldnn submodule version

* empty commit
nswamy pushed a commit that referenced this pull request Apr 5, 2019
* Updated news.md with the latest mkldnn submodule version

* empty commit
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Updated news.md with the latest mkldnn submodule version

* empty commit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants