This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Add MKLDNN header files in include dir#14300
Merged
Merged
Conversation
Member
Author
|
@pengzhao-intel @wuxun-zhang @apeforest please help review |
Member
Author
|
@mxnet-label-bot update [pr-awaiting-review] |
pengzhao-intel
approved these changes
Mar 2, 2019
Contributor
pengzhao-intel
left a comment
There was a problem hiding this comment.
Thanks for the quick fix :)
LGTM
wkcn
approved these changes
Mar 2, 2019
Member
wkcn
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
LGTM : )
Member
|
Thanks. The PR has been Merged : ) |
Member
|
Do you think tools for making pip wheels need be updated accordingly? @szha |
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are hitting segfault when using MKLDNN enabled MXNet library with Horovod. MKLDNN is enabled by default when we are building MXNet from source in Linux OS. This PR adds the MKLDNN header files to the include directory which is needed to properly install Horovod with MKLDNN enabled MXNet library.