This repository was archived by the owner on Nov 17, 2023. It is now read-only.
v1.4.x: Backport of Windows CI Fixes#14420
Merged
marcoabreu merged 4 commits intoMar 14, 2019
Merged
Conversation
fb33f59 to
6324ccc
Compare
Contributor
Author
|
@Chancebair @marcoabreu reviews please |
6324ccc to
1096951
Compare
04ba493 to
f4245bc
Compare
Contributor
|
LGTM |
Chancebair
approved these changes
Mar 13, 2019
marcoabreu
approved these changes
Mar 13, 2019
wkcn
approved these changes
Mar 13, 2019
Member
wkcn
left a comment
There was a problem hiding this comment.
Thanks for your contribution! LGTM
f4245bc to
1e39c1c
Compare
Contributor
|
@mxnet-label-bot add [CI, Windows, pr-awaiting-testing] |
Contributor
|
@perdasilva Thank you for the contribution!. Could you please look into it why CI if failing? |
Member
|
Could you please link the related commit/PR here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports the windows ci changes to v1.4.x branch. I've had to drop the julia tests for windows cpu, since those were added with a different Julia related PR.
Related PRs: #14355 and #14336
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.