This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Use DEFAULT macro in C APIs#14767
Merged
Merged
Conversation
Member
Author
|
@frankfliu Please help review. |
Member
Author
|
@mxnet-label-bot add [pr-awaiting-review] |
Member
Author
|
@wkcn Could you please help review and merge? Thanks. |
Member
|
Thank you for the fix! Why MXInvokeCachedOp is duplicated? Edit: |
Member
|
Merged. Thank you! |
yuxihu
added a commit
to yuxihu/incubator-mxnet
that referenced
this pull request
Apr 24, 2019
* fix C API default values * remove duplicate MXInvokeCachedOp
szha
pushed a commit
that referenced
this pull request
Apr 25, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* fix C API default values * remove duplicate MXInvokeCachedOp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way of specifying the default values in C APIs by using the DEFAULT macro. Otherwise, it will fail compilation with C code. We also remove the duplicate declaration of MXInvokeCachedOp API.