Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1403] Disable numpy's writability of NDArray once it is zero-copied to MXNet#14948

Merged
szha merged 4 commits into
apache:masterfrom
junrushao:zero-copy-patch
May 20, 2019
Merged

[MXNET-1403] Disable numpy's writability of NDArray once it is zero-copied to MXNet#14948
szha merged 4 commits into
apache:masterfrom
junrushao:zero-copy-patch

Conversation

@junrushao
Copy link
Copy Markdown
Member

@junrushao junrushao commented May 14, 2019

Description

Per discussion with @szha , we decided that we do not allow ndarrays to be manipulated on the numpy side to ensure correctness.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Set up writable flags to be False.

Comments

None

@junrushao junrushao requested a review from szha as a code owner May 14, 2019 21:47
szha
szha reviewed May 14, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to completely disable read and write (since we also don't know when the read result would be accurate)? is there a way to declare that the original array no longer has the ownership of the data?

@junrushao
Copy link
Copy Markdown
Member Author

junrushao commented May 15, 2019

@szha I haven't found a way to preventing users from reading the data. array.flags["OWNDATA"] is not allowed to be changed.

@junrushao junrushao changed the title Disable numpy's writability of NDArray once it is zero-copied to MXNet [MXNET-1403] Disable numpy's writability of NDArray once it is zero-copied to MXNet May 15, 2019
marcoabreu
marcoabreu reviewed May 16, 2019
View reviewed changes
Comment thread tests/python/unittest/test_ndarray.py Outdated
@junrushao
Copy link
Copy Markdown
Member Author

junrushao commented May 19, 2019

@szha Hey I updated the document to reflect that we do not wish users to either read or write the numpy's ndarray if zero_copy is enabled.

wkcn
wkcn approved these changes May 20, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! : )

Comment thread tests/python/unittest/test_ndarray.py Outdated
@szha szha merged commit 96b1cde into apache:master May 20, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@junrushao
[MXNET-1403] Disable numpy's writability of NDArray once it is zero-c…
64b7661 
…opied to MXNet (apache#14948)

* Initial commit

* update

* Update test_ndarray.py

* Retrigger
@leezu leezu mentioned this pull request Jul 23, 2019
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@szha szha szha left review comments

@marcoabreu marcoabreu marcoabreu left review comments

@wkcn wkcn wkcn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@junrushao @szha @wkcn @marcoabreu