Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1402] MXNet docs change for 1.4.1 release#14949

Merged
szha merged 11 commits into
apache:masterfrom
junrushao:update-news-and-readme
May 20, 2019
Merged

[MXNET-1402] MXNet docs change for 1.4.1 release#14949
szha merged 11 commits into
apache:masterfrom
junrushao:update-news-and-readme

Conversation

@junrushao
Copy link
Copy Markdown
Member

No description provided.

@junrushao junrushao changed the title Update NEWS.md and README.md for patch release 1.4.1 [WIP] MXNet docs change for 1.4.1 release May 14, 2019
@junrushao junrushao requested a review from szha as a code owner May 14, 2019 23:33
@junrushao junrushao changed the title [WIP] MXNet docs change for 1.4.1 release [MXNET-1402] MXNet docs change for 1.4.1 release May 15, 2019
Copy link
Copy Markdown
Member

@TaoLv TaoLv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. One minor comment. :)

Comment thread docs/install/index.md Outdated
Copy link
Copy Markdown
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the pip package image in my suggestions...
Also, I highly recommend a full site build test to make sure the drop down menus work as expected. Specifically test the versions drop down in the main nav and on the install page.

Comment thread docs/_static/mxnet-theme/index.html Outdated
Comment thread docs/install/index.md Outdated
Comment thread docs/install/index.md Outdated
Comment thread docs/install/index.md Outdated
Comment thread docs/install/index.md Outdated
Comment thread docs/install/index.md Outdated
junrushao and others added 6 commits May 16, 2019 20:58
@szha
Copy link
Copy Markdown
Member

szha commented May 19, 2019

@aaronmarkham @junrushao1994 what's the status? We already released it in github for some time so we should try to get this in and make announcement soon

@junrushao
Copy link
Copy Markdown
Member Author

@szha We are waiting for @zachgk for the Scala build, and other things should be complete

@pinaraltinyilmaz
Copy link
Copy Markdown

@mxnet-label-bot add[Doc, pr-awaiting-response]

@marcoabreu marcoabreu added Doc pr-awaiting-response PR is reviewed and waiting for contributor to respond labels May 20, 2019
@szha szha merged commit 807e40a into apache:master May 20, 2019
@aaronmarkham
Copy link
Copy Markdown
Contributor

Hi @junrushao1994 - Doesn't look like step 6 was done:(https://cwiki.apache.org/confluence/display/MXNET/Release+Process#ReleaseProcess-3.2.UpdatetheMXNetwebsiteupdate-mxnet-website)
Are we ready for that, or still waiting on a different step to finish?

@junrushao
Copy link
Copy Markdown
Member Author

Hey @aaronmarkham, I haven't had CI access yet. Could you help with this? Thanks!

@aaronmarkham
Copy link
Copy Markdown
Contributor

I updated CI... there's a run in progress, so we should see an update around EOD.

haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Initial commit

* Website stuff

* Address comments from Tao

* Update docs/_static/mxnet-theme/index.html

Co-Authored-By: Aaron Markham <[email protected]>

* Update docs/install/index.md

Co-Authored-By: Aaron Markham <[email protected]>

* Update docs/install/index.md

Co-Authored-By: Aaron Markham <[email protected]>

* Update docs/install/index.md

Co-Authored-By: Aaron Markham <[email protected]>

* Update docs/install/index.md

Co-Authored-By: Aaron Markham <[email protected]>

* Update docs/install/index.md

Co-Authored-By: Aaron Markham <[email protected]>

* Retrigger
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Doc pr-awaiting-response PR is reviewed and waiting for contributor to respond

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants