This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[Quantization] Support zero-size tensor input for quantization flow#15031
Merged
Conversation
Contributor
|
@ZhennanQin @TaoLv @xinyu-intel please help take a review. |
Contributor
|
Please also add a test case |
This was referenced May 22, 2019
TaoLv
reviewed
May 22, 2019
652af82 to
bc9760c
Compare
Contributor
Author
|
@pengzhao-intel @TaoLv test case is added, redundant file is remove. Please help to review again:) |
pengzhao-intel
approved these changes
May 22, 2019
Contributor
pengzhao-intel
left a comment
There was a problem hiding this comment.
Thanks for the improvements.
LGTM
TaoLv
approved these changes
May 23, 2019
Contributor
|
LGTM. |
Contributor
|
Thanks for your contribution. Merging now. |
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
…pache#15031) * [Quantization] Support zero-size tensor input for quantization flow * Comment out quantized_act and quantized_sum * retrigger CI * Add test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is to support zero-size tensor input for quantization flow.
Let's take RNN related model as an example, the
begin_stateis always initialized into shape(0, self._num_hidden), it worked well in FP32 pass, but failed in INT8 pass due tounknown dimensionerror with latest MXNet code base.With this patch, models with such inputs are able to be quantized and run in INT8 mode.
@pengzhao-intel @TaoLv @ZhennanQin
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments