This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Restore save/load ndarray to 1.4.1#15073
Merged
szha merged 1 commit intoMay 25, 2019
Merged
Conversation
Contributor
|
We have a backwards compatibility test running constantly. Could you check why it hasnt caught that? |
Contributor
Author
|
@marcoabreu This is specifically about serializing/deserializing zero-size tensors, which are the kind of tensor not supported by any operators in MXNet. For this reason, there were no such test cases in MXNet before, but sockeye has a unit test covering this case. I added a similar test in MXNet to exclude possible incompatible changes in the future. Thanks. |
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR restores the
NDArray::Save/Loadfunctions to 1.4.1 for keeping backward compatibility for saving/loading zero-size tensors. The issue was reported in #14954 (comment) by @DickJC123.This PR depends on #15063. I will rebase this PR after #15063 is merged.
@DickJC123 Since we are not going to have the NumPy shape semantics in the next release, I simply reverted the changes for serialization functions introduced by #14661. After careful thinking, I find that it's required to depend on the compatibility mode to save/load ndarrays in legacy/numpy shape semantics (we will also need a magic version number to guard this when loading). We will deal with it after introducing NumPy operators. Right now, I added
CHECKin save/load functions indicating that numpy shape semantics cannot be turned on.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.