This repository was archived by the owner on Nov 17, 2023. It is now read-only.
move amp test and change op support to warning#15085
Merged
Merged
Conversation
marcoabreu
previously requested changes
May 28, 2019
Contributor
marcoabreu
left a comment
There was a problem hiding this comment.
I'd like to wait for the result of the discussion on dev@ first
Member
Author
|
@marcoabreu I intended to wait until the discussion concludes too. Also, I'd like to remind you that vetos must be accompanied by technical justification https://www.apache.org/foundation/voting.html#Veto. |
Contributor
|
@mxnet-label-bot add [Test] |
reminisce
approved these changes
May 30, 2019
Member
Author
|
met with @ptrendx today and we are proceeding with warning now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
move amp test to follow naming convention for contrib features and change op support to warning
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes