Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-1407] Added test to verify Large Tensor Support for pad operator#15126

Merged
anirudh2290 merged 1 commit into
apache:masterfrom
access2rohit:pad_lts
Oct 18, 2019
Merged

[MXNET-1407] Added test to verify Large Tensor Support for pad operator#15126
anirudh2290 merged 1 commit into
apache:masterfrom
access2rohit:pad_lts

Conversation

@access2rohit
Copy link
Copy Markdown
Contributor

@access2rohit access2rohit commented Jun 2, 2019 •
edited
Loading

Description

new operator supported: pad

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-1407], where 1407 refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@access2rohit
Copy link
Copy Markdown
Contributor Author

access2rohit commented Jun 2, 2019

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jun 2, 2019
@access2rohit access2rohit force-pushed the pad_lts branch 2 times, most recently from e035f0c to 00ec663 Compare June 3, 2019 23:29
@vandanavk
Copy link
Copy Markdown
Contributor

vandanavk commented Jun 16, 2019

@access2rohit could you check the CI and merge conflict?

@roywei
Copy link
Copy Markdown
Member

roywei commented Jul 8, 2019

@access2rohit could you rebase this PR? thanks

@karan6181
Copy link
Copy Markdown
Contributor

karan6181 commented Jul 19, 2019

@access2rohit Could you please re-trigger the CI and resolve the merge conflicts?

@piyushghai
Copy link
Copy Markdown
Contributor

piyushghai commented Aug 2, 2019

@access2rohit Gentle ping...

ChaiBapchya
ChaiBapchya reviewed Aug 3, 2019
View reviewed changes
Comment thread tests/nightly/test_large_array.py Outdated
ChaiBapchya
ChaiBapchya reviewed Aug 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor clarification needed

@ChaiBapchya
Copy link
Copy Markdown
Contributor

ChaiBapchya commented Aug 17, 2019

@access2rohit gentle ping!

@access2rohit access2rohit changed the title [MXNET-1407] Added test to verify Large Tensor Support for pad operator [WIP][MXNET-1407] Added test to verify Large Tensor Support for pad operator Oct 9, 2019
@access2rohit access2rohit changed the title [WIP][MXNET-1407] Added test to verify Large Tensor Support for pad operator [MXNET-1407] Added test to verify Large Tensor Support for pad operator Oct 15, 2019
ChaiBapchya
ChaiBapchya approved these changes Oct 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@access2rohit
Copy link
Copy Markdown
Contributor Author

access2rohit commented Oct 17, 2019

@sxjscience @apeforest @anirudh2290 @zheng-da @pengzhao-intel This PR is ready for review

@access2rohit access2rohit force-pushed the pad_lts branch 2 times, most recently from f89f680 to 7c6b2ee Compare October 18, 2019 15:32
anirudh2290
anirudh2290 reviewed Oct 18, 2019
View reviewed changes
Comment thread src/operator/pad.cc Outdated
index_t oStartY = std::max(index_t{0}, pad_t);
index_t oStartZ = std::max(index_t{0}, pad_f);

int l, ip_x, ip_y, ip_z;
Copy link
Copy Markdown
Member

@anirudh2290 anirudh2290 Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these not changed to index_t. also why is i, j, k inside pragma omp parallel not changed to index_t.

Copy link
Copy Markdown
Contributor Author

@access2rohit access2rohit Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch ... missed it. Will add it now

Copy link
Copy Markdown
Member

@anirudh2290 anirudh2290 Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test, if the current test missed catching this issue.

Copy link
Copy Markdown
Contributor Author

@access2rohit access2rohit Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't added tests for backward pass since initial large tensor support only works for forward passes.

@anirudh2290 anirudh2290 merged commit efa5369 into apache:master Oct 18, 2019
@anirudh2290
Copy link
Copy Markdown
Member

anirudh2290 commented Oct 18, 2019

Please open an issue for the missing tests and remaining todos in Large Tensor Support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@anirudh2290 anirudh2290 anirudh2290 left review comments

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@access2rohit @vandanavk @roywei @karan6181 @piyushghai @ChaiBapchya @anirudh2290 @marcoabreu