Codestin Search App

Zha0q1 · 2019-06-11T05:18:26Z

Description

fix: #15241
I have implemented the new feature.
Need to add test cases.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

vandanavk · 2019-06-11T17:44:23Z

@mxnet-label-bot add [Operator, pr-work-in-progress]

access2rohit · 2019-06-11T20:07:00Z

There are no test cases associated with this new feature introduction. Please add test cases.

access2rohit · 2019-06-11T20:36:24Z

Even if the PR is WIP add the description and explain briefly what feature are you adding to MXNet profiler and show how it adds value over existing profiler

apeforest · 2019-06-14T23:44:59Z

Please add more description to this PR. What was done, what was tested, any limitationn

Zha0q1 · 2019-06-17T22:54:03Z

I have added a new test in test_profiler.py.
I also manually tested using Naive Engine; the result was the same as using ThreadedEngine. It did not seem like adding "os.environ['MXNET_ENGINE_TYPE'] = 'NaiveEngine'" to my new test case in test_profiler.py would work though. @arcadiaphy

access2rohit · 2019-06-17T23:20:51Z

Can you more test cases like:
customOp1 + RegisteredOp + customOp2

Try to include python processing code in all the above cases

anirudh2290

Overall looks good. Lets wait for the CI. Also @arcadiaphy 's review constitutes a veto so I will wait for him to take another look before moving forward with this PR.

anirudh2290 · 2019-06-26T19:04:50Z

@arcadiaphy looks like your comments have been addressed. Can you please take another look ?

* working version * style fix * several fixes * resolve issues in the comments * revert to using thread-safe Get() for singleton class CustomOpProfiler * indentation * Now supports Naive Engine * style fix * tidiness * tests added * style fix * add a new test case which has multiple custom ops * testcases fix * fix * fix style * minor naive engine fix * simplify some branching logic * better desing style * fix * fix * fix * fix * fix * fix * add isprofiling check to onCustomStart * fix * rename dummy_wait * fix conflict * improve test * fix * fix test cases * fix test cases * fix testcases * revert back to reduce overhead * fix style * Re-Trigger build * rename var * Re-Trigger build

This reverts commit 92fce90.

sandeep-krishnamurthy requested review from anirudh2290 and arcadiaphy and removed request for anirudh2290 and arcadiaphy June 11, 2019 05:50

access2rohit reviewed Jun 11, 2019

View reviewed changes

Comment thread src/operator/custom/custom-inl.h Outdated

apache deleted a comment from Zha0q1 Jun 11, 2019

access2rohit reviewed Jun 11, 2019

View reviewed changes

Comment thread src/engine/threaded_engine.cc Outdated

marcoabreu added Operator pr-work-in-progress PR is still work in progress labels Jun 11, 2019

access2rohit reviewed Jun 11, 2019

View reviewed changes