This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Add Large Tensor Support for Sequence, NN Ops #15807
Merged
Merged
Conversation
Contributor
Author
|
@mxnet-label-bot add [work-in-progress] |
apeforest
reviewed
Aug 13, 2019
apeforest
reviewed
Aug 13, 2019
apeforest
reviewed
Aug 13, 2019
apeforest
reviewed
Aug 13, 2019
apeforest
reviewed
Aug 13, 2019
apeforest
approved these changes
Aug 13, 2019
Contributor
apeforest
left a comment
There was a problem hiding this comment.
Thanks for your contribution. LGTM except a few minor comments.
Contributor
|
Remove commented code if its not required ... rest LGTM. Also please rebase your branch with master again and push |
access2rohit
approved these changes
Aug 13, 2019
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* sequence_last, sequence_reverse, sequence_mask * working softmax_cross_entropy * fix linting, add index_copy * add softmax output * add leaky relu * add pooling * add layernorm * add dropout, activation, batchnorm and update layernorm * address comments to remove some comments * handling imports
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* sequence_last, sequence_reverse, sequence_mask * working softmax_cross_entropy * fix linting, add index_copy * add softmax output * add leaky relu * add pooling * add layernorm * add dropout, activation, batchnorm and update layernorm * address comments to remove some comments * handling imports
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* sequence_last, sequence_reverse, sequence_mask * working softmax_cross_entropy * fix linting, add index_copy * add softmax output * add leaky relu * add pooling * add layernorm * add dropout, activation, batchnorm and update layernorm * address comments to remove some comments * handling imports
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* sequence_last, sequence_reverse, sequence_mask * working softmax_cross_entropy * fix linting, add index_copy * add softmax output * add leaky relu * add pooling * add layernorm * add dropout, activation, batchnorm and update layernorm * address comments to remove some comments * handling imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Large tensor support for
Sequence ops -
sequence_last,sequence_reverse,sequence_maskNeural Network ops -
softmax_cross_entropy,SoftmaxOutput,leakyRelu,Pooling,LayerNorm,Dropout,ActivationandBatchNormContrib op -
index_copyChecklist
Essentials
Please feel free to remove inapplicable items for your PR.