This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Reduce memory footprint in Large array nightly tests#15900
Merged
Conversation
Contributor
Author
|
@mxnet-label-bot add [pr-work-in-progress] |
…mory footprint of tests for topk, sort and argsort
fad8886 to
633a370
Compare
Contributor
Author
|
@mxnet-label-bot add [pr-awaiting-review] |
Contributor
Author
|
@apeforest @ChaiBapchya ready for review |
ChaiBapchya
approved these changes
Aug 19, 2019
apeforest
approved these changes
Aug 20, 2019
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
…mory footprint of tests for topk, sort and argsort (apache#15900)
access2rohit
added a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
…mory footprint of tests for topk, sort and argsort (apache#15900)
access2rohit
added a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
…mory footprint of tests for topk, sort and argsort (apache#15900)
access2rohit
added a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
…mory footprint of tests for topk, sort and argsort (apache#15900)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using NDArray primitives instead of using numpy to create an array and calling NDArray constructor on that.
Memory usage of following Ops have significantly been reduced:
topk
sort
argsort
from around 400GB -> under 100GB
(before) (after)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.