This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[Numpy] Fix numerical error in multinomial's pvalue check#16211
Merged
Conversation
haojin2
approved these changes
Sep 20, 2019
Contributor
haojin2
left a comment
There was a problem hiding this comment.
LGTM.
Note: this fix borrows the idea from https://github.com/numpy/numpy/blob/cf70bf20b2e528b2ed74dda2dce7d1d60fa118ea/numpy/random/generator.pyx#L3601
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Sep 26, 2019
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the command
np.random.multinomial(20, pvals=[1/20]*20)would result in error as followed:This is due to the floating number errors cumulated during the check of
pvalslegality.By adding a tiny epsilon the
1.0could resolve the problem in my case.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments