This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Add im2col and col2im operator#16502
Merged
Merged
Conversation
wkcn
reviewed
Oct 18, 2019
Member
wkcn
left a comment
There was a problem hiding this comment.
Thank you for the great contribution!
I think it is necessary to check req == kWriteTo or kInplace in the forward function.
| Shape3(col_shape[0], col_shape[1], col_shape[2]), s); | ||
|
|
||
| for (index_t n = 0; n < num; ++n) { | ||
| im2col(s, im[n].dptr_, im_shape, col_buffer_shape, |
Member
There was a problem hiding this comment.
Could we need to check req == kWriteTo or kInplace?
| for (index_t n = 0; n < num; ++n) { | ||
| col2im(s, col[n].dptr_, im_shape, col_buffer_shape, | ||
| param.kernel, param.pad, param.stride, param.dilate, | ||
| im[n].dptr_, kWriteTo); |
Member
Author
There was a problem hiding this comment.
All fixed. Req types are checked in forward function, too.
d5df50b to
19c98b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes im2col and col2im operator using the functions in im2col.h and im2col.cuh.
#10394
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments