Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Implement numpy operator 'average'#16720

Merged
haojin2 merged 5 commits into
apache:masterfrom
anexpn:np_op_average
Dec 9, 2019
Merged

[Numpy] Implement numpy operator 'average'#16720
haojin2 merged 5 commits into
apache:masterfrom
anexpn:np_op_average

Conversation

@anexpn
Copy link
Copy Markdown
Contributor

@anexpn anexpn commented Nov 4, 2019 •
edited
Loading

Description

Implement the numpy operator 'average'

https://numpy.org/devdocs/reference/generated/numpy.average.html

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • op average, tests, (and when applicable, API doc)

Comments

  • does not guarantee the same behavior with numpy when given float16 dtype and overflow occurs
  • a and weights must be the same dtype

@anexpn
Copy link
Copy Markdown
Contributor Author

anexpn commented Nov 4, 2019

@haojin2

@haojin2 haojin2 added the Numpy label Nov 4, 2019
haojin2
haojin2 reviewed Nov 4, 2019
View reviewed changes
Comment thread include/mxnet/tensor_blob.h Outdated
haojin2
haojin2 reviewed Nov 4, 2019
View reviewed changes
Comment thread python/mxnet/ndarray/numpy/_op.py Outdated
haojin2
haojin2 reviewed Nov 4, 2019
View reviewed changes
Comment thread src/operator/numpy/np_broadcast_reduce_op.h Outdated
haojin2
haojin2 reviewed Nov 4, 2019
View reviewed changes
Comment thread src/operator/numpy/np_broadcast_reduce_op.h Outdated
haojin2
haojin2 reviewed Nov 4, 2019
View reviewed changes
Comment thread src/operator/numpy/np_broadcast_reduce_op_value.cc Outdated
haojin2
haojin2 reviewed Nov 4, 2019
View reviewed changes
Comment thread tests/python/unittest/test_numpy_op.py
haojin2
haojin2 reviewed Nov 4, 2019
View reviewed changes
Comment thread tests/python/unittest/test_numpy_op.py Outdated
haojin2
haojin2 reviewed Nov 4, 2019
View reviewed changes
Comment thread src/operator/numpy/np_broadcast_reduce_op.h Outdated
haojin2
haojin2 reviewed Nov 4, 2019
View reviewed changes
Comment thread src/operator/numpy/np_broadcast_reduce_op.h Outdated
anexpn
anexpn commented Nov 4, 2019
View reviewed changes
Comment thread python/mxnet/symbol/numpy/_symbol.py
anexpn
anexpn commented Nov 4, 2019
View reviewed changes
Comment thread python/mxnet/symbol/numpy/_symbol.py
anexpn
anexpn commented Nov 4, 2019
View reviewed changes
Comment thread python/mxnet/numpy/multiarray.py
Comment thread python/mxnet/numpy/multiarray.py
Comment thread python/mxnet/ndarray/numpy/_op.py
Comment thread python/mxnet/ndarray/numpy/_op.py
haojin2
haojin2 approved these changes Nov 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @reminisce Any extra comments?

reminisce
reminisce reviewed Nov 14, 2019
View reviewed changes
Comment thread include/mxnet/tensor_blob.h Outdated
Comment thread include/mxnet/tensor_blob.h Outdated
Comment thread tests/python/unittest/test_numpy_op.py Outdated
@anexpn anexpn force-pushed the np_op_average branch 5 times, most recently from 1ae8dcc to 4ed05fa Compare November 26, 2019 17:43
@anexpn
Complete forward and backward
396f0af 
Add tests

Implement returned

Implement none weights returned

Replace reduce implementation with workspace version

Temp space can be requested only once.

Use FNumVisibleOutputs attribute, always return sum of weights

Fix bug

Fix GPU bug

Fix GPU bug

Formatting

Apply suggestions from code review

two blank lines between python functions

Fix pylint

Fix GPU bug

Add support for null and addTo reqs

Remove TBlob constructors

Refactor
@anexpn
Copy link
Copy Markdown
Contributor Author

anexpn commented Dec 8, 2019

@haojin2 ready to be merged

@haojin2 haojin2 merged commit 44cd63e into apache:master Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin

@szha szha Awaiting requested review from szha szha is a code owner

2 more reviewers

@reminisce reminisce reminisce left review comments

@haojin2 haojin2 haojin2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Numpy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anexpn @reminisce @haojin2