Enabling large tensor support for binary broadcast operators#16755
Conversation
|
LGTM ! Also paste the output for tests run. |
|
Build flag Output of test run |
hypot can work for vector too (it takes 2 values as input which basically act as 2 sides of the triangle) - shape of the 2 values has to be the same / broadcastable |
|
Vector test |
Did also you run the whole suite for tensor and vector ? |
2d2ce43 to
e1214a1
Compare
This reverts commit 3d12ed2.
However, tvm_add test fails when individual dimension size > 2**32. Verified with @yzhliu that change needs to be done on the tvm side. It's a non-trivial change. and thus the test_tvm_add will be added in subsequent separate PR. |
Yes. As noted previously, on 480GB CPU test_large_array needs to be run twice (first half tests followed by second half tests approx) due to memory free-ing issue. |
Description
In continuation of #16714
Add tests
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes