Link fixes4 #16764

TEChopra1000 · 2019-11-08T18:26:13Z

A new round of link fixes.

iblislin

The Julia part is fine for me. 👍

iblislin · 2019-11-09T03:42:41Z

julia/docs/src/tutorial/char-lstm.md

 We will be using fixed-length input sequence for training. The code is
 adapted from the [char-rnn example for MXNet's Python
-binding](https://github.com/dmlc/mxnet-notebooks/blob/master/python/tutorials/char_lstm.ipynb),
+binding](/api/r/docs/tutorials/char_rnn_model),


ah, is there a Python tutorial on the web site?

@iblis17 there is this one: https://mxnet.apache.org/api/r/docs/tutorials/char_rnn_model.

well, I think it's R's, not Python.

Ah I overlooked that. What about this? https://github.com/apache/incubator-mxnet/blob/8004a027ad6a73f8f6eae102de8d249fbdfb9a2d/example/rnn/old/char-rnn.ipynb

Ah, nice, that's the correct one.

docs/python_docs/python/tutorials/index.rst

TEChopra1000

fixed site-link for python char-rnn tutorial.

julia/docs/src/tutorial/char-lstm.md

ChaiBapchya · 2019-11-11T22:36:31Z

@aaronmarkham @TEChopra1000
The reason why you were facing MKLDNN lib error was
Your branch was likely not updated with latest master

Your error - MKLDNN lib not found - #16629
Fixed in this PR - #16690
Needs to be included in your branch.

Steps to merge

git remote add upstream https://github.com/apache/incubator-mxnet

git checkout master
git fetch upstream master
git merge upstream/master
git push origin master

This updates your master
Now update your feature branch

git checkout <branchname>
git merge master
git push origin <branchname>

Hope this helps.

TEChopra1000 · 2019-11-13T00:23:24Z

@aaronmarkham would you be willing to merge these link fixes?

ChaiBapchya

Let's get this merged!

ys2843 · 2020-06-19T00:10:16Z

docs/python_docs/python/tutorials/getting-started/gluon_from_experiment_to_deployment.md


-Here we will briefly introduce how to run inference using Module API in Python. There is more detailed explanation available in the [Predict Image Tutorial](https://mxnet.apache.org/tutorials/python/predict_image.html).
-In general, prediction consists of the following steps:
+Here we will briefly introduce how to run inference using Module API in Python. In general, prediction consists of the following steps:


This is the broken link discussed in #16724

Do you want to add it back? or the image-classification shouldn't exist anymore? What's the solution for that issue?

@ChaiBapchya #16724 is still open, I wondered if something is pending. I personally don't know the expect solution, if everything is good we can close it.

But following link was mentioned in the issue, not sure if this need to be considered.

True link should be -- https://github.com/dmlc/mxnet-notebooks/blob/master/python/tutorials/predict_imagenet.ipynb

I see there was a link which previously existed. Now the link has been removed. Have a word with Aaron/Talia they have a better idea.

TEChopra1000 requested review from aaronmarkham, iblislin and szha as code owners November 8, 2019 18:26

iblislin approved these changes Nov 9, 2019

View reviewed changes

iblislin reviewed Nov 9, 2019

View reviewed changes

TEChopra1000 commented Nov 9, 2019

View reviewed changes

docs/python_docs/python/tutorials/index.rst Outdated Show resolved Hide resolved

TEChopra1000 commented Nov 11, 2019

View reviewed changes

julia/docs/src/tutorial/char-lstm.md Outdated Show resolved Hide resolved

TEChopra1000 and others added 5 commits November 12, 2019 13:26

a new round of link fixes

c6402fa

fixing merge conflict

de541cd

Nudging test.

0b2fa23

Update julia/docs/src/tutorial/char-lstm.md

d486e2d

fixing mkldnn version to match upstream/master

40099d7

TEChopra1000 force-pushed the link_fixes4 branch from ee698e7 to 40099d7 Compare November 12, 2019 21:28

ChaiBapchya approved these changes Nov 13, 2019

View reviewed changes

iblislin merged commit 47fd3a0 into apache:master Nov 13, 2019

TEChopra1000 deleted the link_fixes4 branch December 2, 2019 22:14

ys2843 reviewed Jun 19, 2020

View reviewed changes

ys2843 mentioned this pull request Jun 19, 2020

Example link of the image classification show 404 #16724

Closed

Link fixes4 #16764

Link fixes4 #16764

Uh oh!

Conversation

TEChopra1000 commented Nov 8, 2019

Uh oh!

iblislin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TEChopra1000 Nov 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TEChopra1000 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ChaiBapchya commented Nov 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TEChopra1000 commented Nov 13, 2019

Uh oh!

ChaiBapchya left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TEChopra1000 Nov 9, 2019 •

edited

Loading

ChaiBapchya commented Nov 11, 2019 •

edited

Loading