This repository was archived by the owner on Nov 17, 2023. It is now read-only.
gather_nd: check bound and wrap negative indices#17208
Merged
Merged
Conversation
4662785 to
670f7b2
Compare
reminisce
reviewed
Jan 6, 2020
Contributor
reminisce
left a comment
There was a problem hiding this comment.
Please add unit tests for catching IndexError exception.
haojin2
reviewed
Jan 6, 2020
Contributor
|
Maybe also add some tests to verify this new checking. |
670f7b2 to
37fe68a
Compare
37fe68a to
fc8e7c6
Compare
gather_nd: increase the interpretability of the error msg gather_nd: update test
fc8e7c6 to
8e90086
Compare
haojin2
reviewed
Jan 8, 2020
Member
|
@szha we should not mix commits in a PR. It makes it hard to search for the commit that fixes " NormalizeError" APIs |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check if indices are out of bound
wrap negative indices
move NormalizeError out of c_api_error.h