Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[OpPerf] Add Neural network loss ops#17482

Merged
apeforest merged 4 commits into
apache:masterfrom
ChaiBapchya:nn_loss_ops
Feb 3, 2020
Merged

[OpPerf] Add Neural network loss ops#17482
apeforest merged 4 commits into
apache:masterfrom
ChaiBapchya:nn_loss_ops

Conversation

@ChaiBapchya
Copy link
Copy Markdown
Contributor

@ChaiBapchya ChaiBapchya commented Jan 30, 2020 •
edited
Loading

Description

Added Neural Network loss operators to the existing set of opperf benchmarks

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Added following ops
  1. smooth_l1
  2. CTCLoss [ctc_loss added as alias]
  3. MakeLoss
  4. softmax_cross_entropy

Results

from benchmark.opperf.nd_operations.nn_loss_operators import run_loss_operators_benchmarks
 run_loss_operators_benchmarks()

INFO:root:Begin Benchmark - CTCLoss
INFO:root:Complete Benchmark - CTCLoss
INFO:root:Begin Benchmark - MakeLoss
INFO:root:Complete Benchmark - MakeLoss
INFO:root:Begin Benchmark - ctc_loss
INFO:root:Complete Benchmark - ctc_loss
INFO:root:Begin Benchmark - smooth_l1
INFO:root:Complete Benchmark - smooth_l1
INFO:root:Begin Benchmark - softmax_cross_entropy
INFO:root:Complete Benchmark - softmax_cross_entropy

CPU - https://gist.github.com/ChaiBapchya/fb608c551689d3a4ff48c3be5030a2e2

Comments

@sandeep-krishnamurthy @apeforest @connorgoggins

This was referenced Jan 30, 2020
Open
Open
connorgoggins
connorgoggins reviewed Jan 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@connorgoggins connorgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small variable name change.

Comment thread benchmark/opperf/nd_operations/nn_loss_operators.py Outdated
Comment thread benchmark/opperf/nd_operations/nn_loss_operators.py Outdated
Comment thread benchmark/opperf/utils/benchmark_utils.py
@ChaiBapchya
Copy link
Copy Markdown
Contributor Author

ChaiBapchya commented Jan 30, 2020

GPU : https://gist.github.com/ChaiBapchya/fac7310f7d167d1361854451e7daa342

@ChaiBapchya
Copy link
Copy Markdown
Contributor Author

ChaiBapchya commented Jan 31, 2020

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jan 31, 2020
apeforest
apeforest reviewed Jan 31, 2020
View reviewed changes
Comment thread benchmark/opperf/utils/profiler_utils.py
@ChaiBapchya ChaiBapchya mentioned this pull request Feb 2, 2020
Open
@ChaiBapchya
Copy link
Copy Markdown
Contributor Author

ChaiBapchya commented Feb 3, 2020

@mxnet-label-bot add [pr-awaiting-merge]

@lanking520 lanking520 added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Feb 3, 2020
@apeforest apeforest merged commit 88cc54d into apache:master Feb 3, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
@ChaiBapchya
[OpPerf] Add Neural network loss ops (apache#17482)
dd6a881 
* add loss ops and fix minor typo in array_rearrange

* fix issues with ops, still no backward for softmax_cross_entropy

* fix names

* add profiler param to function description
@ChaiBapchya ChaiBapchya deleted the nn_loss_ops branch June 24, 2020 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandeep-krishnamurthy sandeep-krishnamurthy Awaiting requested review from sandeep-krishnamurthy

2 more reviewers

@connorgoggins connorgoggins connorgoggins left review comments

@apeforest apeforest apeforest approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ChaiBapchya @apeforest @connorgoggins @lanking520