This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[OpPerf] Fix markdown for native profile and add profile param in function desc#17494
Merged
Conversation
Contributor
Author
|
@mxnet-label-bot add [pr-awaiting-review] |
connorgoggins
approved these changes
Jan 31, 2020
Contributor
connorgoggins
left a comment
There was a problem hiding this comment.
LGTM! Nice work :)
Contributor
Author
|
@mxnet-label-bot add [pr-awaiting-review] |
Contributor
Author
|
Updated markdown result |
apeforest
approved these changes
Jan 31, 2020
This was referenced Jan 31, 2020
Contributor
Author
|
@mxnet-label-bot update [pr-awaiting-merge] |
zheyuye
pushed a commit
to zheyuye/incubator-mxnet
that referenced
this pull request
Feb 19, 2020
…ction desc (apache#17494) * 5 columns instead of 6 for native profile * add profiler param in function description
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 29, 2020
…ction desc (apache#17494) * 5 columns instead of 6 for native profile * add profiler param in function description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix markdown for native profile
Native profile has 5 columns where as Python profile has 6
Native : "| Operator | Avg Forward Time (ms) | Avg. Backward Time (ms) | Max Mem Usage (Storage) (Bytes) | Inputs |"
Python : "| Operator | Avg Time (ms) | P50 Time (ms) | P90 Time (ms) | P99 Time (ms) | Inputs |")
5 columns instead of 6 for native profile
Add profile param in function descriptions
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
benchmark/opperf/utils/common_utils.py
Verified the markdown file that this generates.