Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Doc fix for np.argmax and np.argmin#17604

Merged
haojin2 merged 1 commit into
apache:masterfrom
haojin2:arg_type_fix_doc
Feb 17, 2020
Merged

Doc fix for np.argmax and np.argmin#17604
haojin2 merged 1 commit into
apache:masterfrom
haojin2:arg_type_fix_doc

Conversation

@haojin2
Copy link
Copy Markdown
Contributor

@haojin2 haojin2 commented Feb 15, 2020

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Doc fix

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@haojin2 haojin2 requested a review from reminisce February 15, 2020 07:59
@haojin2 haojin2 requested a review from szha as a code owner February 15, 2020 07:59
@haojin2 haojin2 self-assigned this Feb 15, 2020
@haojin2 haojin2 merged commit 1133bfa into apache:master Feb 17, 2020
zheyuye pushed a commit to zheyuye/incubator-mxnet that referenced this pull request Feb 19, 2020
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants