Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Improve createOpState for custom ops #19103

Merged
samskalicky merged 4 commits into from
Sep 11, 2020
Merged

Improve createOpState for custom ops #19103

samskalicky merged 4 commits into from
Sep 11, 2020

Conversation

@samskalicky
Copy link
Contributor

@samskalicky samskalicky commented Sep 9, 2020 •
edited
Loading

Description

Support passing all args from createOpState to custom ops: context, input shapes & types

  • Also updates test_gemm.py and test_relu.py for custom ops on 2.0 now that Symbol.bind is deprecated

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

mxnet-bot commented Sep 9, 2020

Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, miscellaneous, edge, sanity, windows-gpu, unix-cpu, centos-gpu, clang, centos-cpu, windows-cpu, website]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@samskalicky
Copy link
Contributor Author

samskalicky commented Sep 10, 2020

@mseth10 @rondogency this is a small PR with just the change for custom stateful ops. Please review, thanks!

@samskalicky samskalicky changed the title [WIP] improve createOpState for custom ops Improve createOpState for custom ops Sep 10, 2020
@samskalicky samskalicky added the pr-awaiting-review PR is waiting for code review label Sep 10, 2020
@szha
Copy link
Member

szha commented Sep 10, 2020

thanks for the enhancement! as we are approaching the (beta) release of mxnet, do you think the API would be finalized with this PR?

@samskalicky
Copy link
Contributor Author

samskalicky commented Sep 10, 2020

I think so, with this PR the examples are all up to date now with Gluon (having removed the symbol bind/executor stuff).

As with anything, as it gets more use we'll find ways to improve things. But we're ready to start helping users extend MXNet!

mseth10
mseth10 approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

karan6181
karan6181 approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@karan6181 karan6181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank You for you contribution!

@rondogency
Copy link
Contributor

rondogency commented Sep 10, 2020

One quick request, in terms of the test, can you add an end-to-end test training example written in gluon like this one: #18167, so that we can have better test suite on performance to show to user

rondogency
rondogency approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@rondogency rondogency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! the above comment can be addressed in the future PR

@samskalicky samskalicky merged commit e5a7814 into apache:master Sep 11, 2020
This was referenced Sep 11, 2020
Merged
Merged
samskalicky added a commit that referenced this pull request Sep 14, 2020
@samskalicky
[1.x] Backport #19103 (#19117)
9383282 
* initial commit

* incremented version number

Co-authored-by: Ubuntu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

3 more reviewers

@rondogency rondogency rondogency approved these changes

@karan6181 karan6181 karan6181 approved these changes

@mseth10 mseth10 mseth10 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@samskalicky @mxnet-bot @szha @rondogency @karan6181 @mseth10