Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[FEATURE] Add new benchmark function for single operator comparison #20388

Merged
akarbown merged 1 commit into from
Jul 28, 2021
Merged

[FEATURE] Add new benchmark function for single operator comparison #20388

akarbown merged 1 commit into from
Jul 28, 2021

Conversation

@agrabows
Copy link
Contributor

@agrabows agrabows commented Jun 25, 2021

Description

This change is about adding new compare operators functionality to MXNet Operator Performance Benchmarks and also enable existing functions to run mx.np/mx.npx operators.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • Code is well-documented

Changes

  • Modified existing function for mx.nd module operators benchmarking to be able to run mx.np/mx.npx operators.
  • Added function allowing comparison of operators between modules
  • Updated README file

@mxnet-bot
Copy link

mxnet-bot commented Jun 25, 2021

Hey @agrabows , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, unix-gpu, centos-gpu, windows-gpu, centos-cpu, windows-cpu, sanity, website, miscellaneous, clang, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 25, 2021
@agrabows
Copy link
Contributor Author

agrabows commented Jun 28, 2021

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

mxnet-bot commented Jun 28, 2021

Jenkins CI successfully triggered : [unix-cpu]

@agrabows
Copy link
Contributor Author

agrabows commented Jun 28, 2021

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

mxnet-bot commented Jun 28, 2021

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jun 28, 2021
@agrabows agrabows force-pushed the benchmark_operators branch from 4000ae9 to d5212b4 Compare June 28, 2021 12:45
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 28, 2021
@akarbown akarbown merged commit 7077bc4 into apache:master Jul 28, 2021
sakibguy added a commit to sakibguy/incubator-mxnet that referenced this pull request Jul 30, 2021
@sakibguy
Merge pull request #2 from apache/master
8a4947c 
Add new benchmark function for single operator comparison (apache#20388)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@akarbown akarbown akarbown approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@agrabows @mxnet-bot @akarbown @mseth10 @agrabow