Draft
Conversation
Validates that enforceConsumptionInOrder correctly handles out-of-order segment state transitions during partial upsert with INCREMENT strategy. Uses a 2-server setup with delay injection on Server 0's segment 1 consuming transition to reproduce the race condition where segment N+1 starts consuming before segment N's data is in the upsert metadata. - DelayInjectingRealtimeTableDataManager: extends RealtimeTableDataManager with configurable consuming/online delays and tracking for segment state at consume start and CRC mismatch detection via replaceSegmentIfCrcMismatch - DelayInjectingTableDataManagerProvider: custom provider that wires delay config from server properties to the injecting data manager - Test verifies enforced table produces correct scores (1020 for player 101) while non-enforced table may show degraded scores (420) Co-Authored-By: Claude Opus 4.6 <[email protected]>
…n tests Read player scores directly from each server's segment data via _serverStarters, bypassing the broker. This makes per-server assertions deterministic instead of depending on unpredictable broker routing. Both enforced and non-enforced tests now assert: - Server 0 (delayed): degraded player 101 score (420) - Server 1 (normal): correct player 101 score (1020) Co-Authored-By: Claude Opus 4.6 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17796 +/- ##
============================================
+ Coverage 63.24% 63.29% +0.05%
Complexity 1454 1454
============================================
Files 3176 3189 +13
Lines 190984 191589 +605
Branches 29202 29302 +100
============================================
+ Hits 120780 121271 +491
- Misses 60784 60839 +55
- Partials 9420 9479 +59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.