Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Defined a new broker metric for total query processing time #8941

Merged
npawar merged 3 commits into
apache:masterfrom
navina:query-metrics
Jun 24, 2022
Merged

Defined a new broker metric for total query processing time #8941
npawar merged 3 commits into
apache:masterfrom
navina:query-metrics

Conversation

@navina

@navina navina commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Defined a new broker metric for total query processing time and added metric to broker.yaml

Tags to include: observability , release notes

Release Notes:

Includes a new broker timer type metric - queryTotalTimeMs

@navina

navina commented Jun 21, 2022

Copy link
Copy Markdown
Contributor Author

Review pls : @npawar

@npawar npawar added release-notes Referenced by PRs that need attention when compiling the next release notes observability Related to observability (logging, tracing, metrics) labels Jun 21, 2022
Comment thread pinot-controller/src/main/resources/package-lock.json
@kishoreg

Copy link
Copy Markdown
Member

How is this different from the totaltimems that we have today?

@navina

navina commented Jun 21, 2022

Copy link
Copy Markdown
Contributor Author

How is this different from the totaltimems that we have today?

Are you referring to BrokerQueryPhase.QUERY_EXECUTION metric? It is currently defined as:

_brokerMetrics.addPhaseTiming(rawTableName, BrokerQueryPhase.QUERY_EXECUTION,
        executionEndTimeNs - routingEndTimeNs);

So, it is not the total query processing time. Total query time should start from the request compilation phase and all the way to the end.

@navina

navina commented Jun 24, 2022

Copy link
Copy Markdown
Contributor Author

@npawar can you merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

observability Related to observability (logging, tracing, metrics) release-notes Referenced by PRs that need attention when compiling the next release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants