Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replace lodash.flatten() with Array.flat() built-in #8928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SourceR85 merged 1 commit into from
Apr 20, 2024
Merged

Replace lodash.flatten() with Array.flat() built-in #8928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bin/update-package-json-for-publish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var path = require('path');
var glob = require('glob');
var findRequires = require('find-requires');
var builtinModules = require('builtin-modules');
const { flatten, uniq } = require('lodash');
const { uniq } = require('lodash');

var topPkg = JSON.parse(fs.readFileSync('./package.json', 'utf8'));
var modules = fs.readdirSync('./packages/node_modules');
Expand All @@ -24,14 +24,14 @@ modules.forEach(function (mod) {

// for the dependencies, find all require() calls
var srcFiles = glob.sync(path.join(pkgDir, 'lib/**/*.js'));
var uniqDeps = uniq(flatten(srcFiles.map(function (srcFile) {
var uniqDeps = uniq(srcFiles.map(function (srcFile) {
var code = fs.readFileSync(srcFile, 'utf8');
try {
return findRequires(code);
} catch (e) {
return []; // happens if this is an es6 module, parsing fails
}
}))).filter(function (dep) {
}).flat()).filter(function (dep) {
// some modules require() themselves, e.g. for plugins
return dep !== pkg.name &&
// exclude built-ins like 'inherits', 'fs', etc.
Expand Down