Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

guyinyou
Copy link
Contributor

…control

  • Add configuration to control runningFlags usage in CommitLog (default: false)
  • Update CommitLog and AllocateMappedFileService to respect the configuration
  • Users can enable runningFlags validation as needed

Which Issue(s) This PR Fixes

Fixes #9709

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.10%. Comparing base (0e72809) to head (4f09def).

Files with missing lines Patch % Lines
...ache/rocketmq/store/AllocateMappedFileService.java 40.00% 2 Missing and 1 partial ⚠️
...ache/rocketmq/store/config/MessageStoreConfig.java 50.00% 2 Missing ⚠️
...main/java/org/apache/rocketmq/store/CommitLog.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9710      +/-   ##
=============================================
- Coverage      48.19%   48.10%   -0.09%     
+ Complexity     12161    12136      -25     
=============================================
  Files           1313     1313              
  Lines          93233    93240       +7     
  Branches       11944    11946       +2     
=============================================
- Hits           44934    44856      -78     
- Misses         42734    42801      +67     
- Partials        5565     5583      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…control

- Add configuration to control runningFlags usage in CommitLog (default: false)
- Update CommitLog and AllocateMappedFileService to respect the configuration
- Users can enable runningFlags validation as needed
@guyinyou guyinyou force-pushed the dev_add_enableRunningFlagsInFlush branch from 6116ab0 to 4f09def Compare September 19, 2025 01:50
@RongtongJin RongtongJin merged commit dbd935f into apache:develop Sep 19, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add enableRunningFlagsInFlush configuration switch for CommitLog
3 participants