bug fix: concurrent increase by CounterWindow may cause PriorityQueue breaken#12505
Merged
kezhenxu94 merged 3 commits intoapache:masterfrom Aug 4, 2024
Merged
bug fix: concurrent increase by CounterWindow may cause PriorityQueue breaken#12505kezhenxu94 merged 3 commits intoapache:masterfrom
kezhenxu94 merged 3 commits intoapache:masterfrom
Conversation
added 2 commits
August 2, 2024 15:02
Member
|
@kezhenxu94 Docker compose somehow missing. Could you check CI env as well? |
Contributor
I had the same problem as well, I think the command |
Member
We fixed it through new e2e tool version. |
kezhenxu94
approved these changes
Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix <#12503>
as org.apache.skywalking.oap.meter.analyzer.dsl.counter.CounterWindow are single instance, the windows which type ConcurrentHashMap will return the same PriorityQueue object for the same meter, when the same meter increase with concurrent call, some unexcpected exception will occur in PriorityQueue object, source code:
CHANGESlog.