Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JarvisG495
Copy link
Contributor

@JarvisG495 JarvisG495 commented Sep 28, 2021

swctl dependency instance [clientService-id] [serverService-id] [--start=start-time] [--end=end-time]

Query the instance topology based on the given clientServiceID and serverServiceID. Results are in JSON format.

Closes apache/skywalking#7822

@kezhenxu94 kezhenxu94 requested a review from fgksgf September 28, 2021 06:59
@kezhenxu94 kezhenxu94 added the feature this pull request provides new feature label Sep 28, 2021
@kezhenxu94 kezhenxu94 added this to the 0.9.0 milestone Sep 28, 2021
@kezhenxu94
Copy link
Member

@wankai123 FYI

@JarvisG495 JarvisG495 marked this pull request as ready for review September 28, 2021 07:02
wu-sheng
wu-sheng previously approved these changes Sep 28, 2021
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command parameters look good to me. Wait for code review.

${swctl} --display=json dependency endpoint "test" > /dev/null 2>&1
${swctl} --display=json dependency endpoint "test" > /dev/null 2>&1

${swctl} --display=json dependency endpoint "test" > /dev/null 2>&1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate? Or copy-paste problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. It should be {swctl} --display=json dependency instance "test" "test".

fix a duplicate test command in test_commands.sh
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JarvisG495 !!!

@kezhenxu94 kezhenxu94 merged commit 7742a5c into apache:master Sep 29, 2021
@wu-sheng
Copy link
Member

@JarvisG495 When you have time and if you have interest, I hope you could enhance this CLI a little more. Add service name, instance name, endpoint name for metrics, dependency, trace, log query.

We have to use complex shell command to get id first, then do real query. The 2 side effects are

  1. It is not very readable.
  2. Different OS platforms(especially Linux VS Windows), they can't share the same command.

@JarvisG495
Copy link
Contributor Author

@JarvisG495 When you have time and if you have interest, I hope you could enhance this CLI a little more. Add service name, instance name, endpoint name for metrics, dependency, trace, log query.

We have to use complex shell command to get id first, then do real query. The 2 side effects are

  1. It is not very readable.
  2. Different OS platforms(especially Linux VS Windows), they can't share the same command.

OK. I will try to implement that in the following weeks.
I also planned to add graphical display for 'dependency' command, but have not finished it yet.

@wu-sheng
Copy link
Member

That is cool 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature this pull request provides new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI] Support command dependency instance

3 participants