-
Notifications
You must be signed in to change notification settings - Fork 47
Add the sub-command 'instance' of command 'dependency' #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@wankai123 FYI |
wu-sheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command parameters look good to me. Wait for code review.
scripts/test_commands.sh
Outdated
| ${swctl} --display=json dependency endpoint "test" > /dev/null 2>&1 | ||
| ${swctl} --display=json dependency endpoint "test" > /dev/null 2>&1 | ||
|
|
||
| ${swctl} --display=json dependency endpoint "test" > /dev/null 2>&1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate? Or copy-paste problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. It should be {swctl} --display=json dependency instance "test" "test".
fix a duplicate test command in test_commands.sh
kezhenxu94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @JarvisG495 !!!
|
@JarvisG495 When you have time and if you have interest, I hope you could enhance this CLI a little more. Add We have to use complex shell command to
|
OK. I will try to implement that in the following weeks. |
|
That is cool 😄 |
swctl dependency instance [clientService-id] [serverService-id] [--start=start-time] [--end=end-time]
Query the instance topology based on the given clientServiceID and serverServiceID. Results are in JSON format.
Closes apache/skywalking#7822