Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Migrate tests to infra-e2e, overhaul the flags names #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wu-sheng merged 1 commit into from
Oct 8, 2021
Merged

Migrate tests to infra-e2e, overhaul the flags names #119

wu-sheng merged 1 commit into from
Oct 8, 2021

Conversation

@kezhenxu94
Copy link
Member

@kezhenxu94 kezhenxu94 commented Oct 7, 2021 •
edited
Loading

  • Remove the command documentations and move them into the command
    help manual.
  • Upgrade urfave/cli to v2.
  • Upgrade to Go 1.16

@kezhenxu94 kezhenxu94 force-pushed the flags branch 8 times, most recently from 5e441c7 to 2dbd29f Compare October 8, 2021 02:56
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021 •
edited
Loading

Codecov Report

Merging #119 (0b8666d) into master (c58e726) will decrease coverage by 15.14%.
The diff coverage is 1.94%.

❗ Current head 0b8666d differs from pull request most recent head 60b920f. Consider uploading reports for the commit 60b920f to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #119       +/-   ##
===========================================
- Coverage   44.62%   29.47%   -15.15%     
===========================================
  Files          15       18        +3     
  Lines         251      380      +129     
===========================================
  Hits          112      112               
- Misses        131      260      +129     
  Partials        8        8
Impacted Files Coverage Δ
internal/commands/interceptor/endpoint.go 0.00% <0.00%> (ø)
internal/commands/interceptor/entity.go 0.00% <0.00%> (ø)
internal/commands/interceptor/instance.go 0.00% <0.00%> (ø)
internal/commands/interceptor/interceptor.go 0.00% <0.00%> (ø)
internal/commands/interceptor/service.go 0.00% <0.00%> (ø)
internal/commands/interceptor/timezone.go 0.00% <0.00%> (ø)
pkg/util/commandNotFound.go 50.00% <0.00%> (ø)
internal/commands/interceptor/duration.go 49.05% <33.33%> (ø)
internal/commands/interceptor/event.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a575f65...60b920f. Read the comment docs.

@kezhenxu94 kezhenxu94 force-pushed the flags branch 4 times, most recently from 019042c to 48f97f7 Compare October 8, 2021 04:09
@kezhenxu94 kezhenxu94 marked this pull request as ready for review October 8, 2021 04:12
@kezhenxu94 kezhenxu94 requested review from fgksgf and wu-sheng October 8, 2021 04:12
@kezhenxu94 kezhenxu94 added this to the 0.9.0 milestone Oct 8, 2021
@kezhenxu94 kezhenxu94 added chore Chores of the project enhancement New feature or request test labels Oct 8, 2021
@kezhenxu94 kezhenxu94 requested a review from mrproliu October 8, 2021 04:14
@kezhenxu94
Migrate tests to infra-e2e, overhaul the flags names
5867c63 
- Remove the command documentations and move them into the command
help manual.
- Upgrade urfave/cli to v2.
@wu-sheng wu-sheng merged commit 352022d into master Oct 8, 2021
@kezhenxu94 kezhenxu94 deleted the flags branch October 8, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@fgksgf fgksgf Awaiting requested review from fgksgf

@mrproliu mrproliu Awaiting requested review from mrproliu

Assignees

No one assigned

Labels

chore Chores of the project enhancement New feature or request test

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kezhenxu94 @codecov-commenter @wu-sheng