Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kezhenxu94
Copy link
Member

No description provided.

@kezhenxu94 kezhenxu94 added the bug Something isn't working label Oct 9, 2021
@kezhenxu94 kezhenxu94 added this to the 0.9.0 milestone Oct 9, 2021
@kezhenxu94 kezhenxu94 requested a review from wankai123 October 9, 2021 05:54
wankai123
wankai123 previously approved these changes Oct 9, 2021
@kezhenxu94
Copy link
Member Author

Wait, service-id is redefined...

wankai123
wankai123 previously approved these changes Oct 9, 2021
Copy link
Member

@wankai123 wankai123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait..

@codecov-commenter
Copy link

Codecov Report

Merging #121 (ed0c372) into master (76f9f84) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

❗ Current head ed0c372 differs from pull request most recent head ce8b0ce. Consider uploading reports for the commit ce8b0ce to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   29.47%   29.24%   -0.24%     
==========================================
  Files          18       18              
  Lines         380      383       +3     
==========================================
  Hits          112      112              
- Misses        260      263       +3     
  Partials        8        8              
Impacted Files Coverage Δ
internal/commands/interceptor/endpoint.go 0.00% <0.00%> (ø)
internal/commands/interceptor/entity.go 0.00% <0.00%> (ø)
internal/commands/interceptor/instance.go 0.00% <0.00%> (ø)
internal/commands/interceptor/service.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f9f84...ce8b0ce. Read the comment docs.

@kezhenxu94 kezhenxu94 force-pushed the destServiceID branch 2 times, most recently from c2ff8c7 to f70d393 Compare October 9, 2021 07:33
@wu-sheng
Copy link
Member

wu-sheng commented Oct 9, 2021

You missed the document, please update.

@kezhenxu94
Copy link
Member Author

You missed the document, please update.

We don't have document now, they are built in the command

@wu-sheng
Copy link
Member

wu-sheng commented Oct 9, 2021

I mean about dependency command, which has the name parameters, right?

@kezhenxu94
Copy link
Member Author

We don't bother to maintain a separate documentation outside the CLI itself anymore, as a CLI, it's much more straightforward to type swctl help or swctl help dependency than looking up a doc elsewhere.

@wankai123
Copy link
Member

We don't bother to maintain a separate documentation outside the CLI itself anymore, as a CLI, it's much more straightforward to type swctl help or swctl help dependency than looking up a doc elsewhere.

The command args in the readme.md seems outdated, should remove or update.

@wu-sheng
Copy link
Member

wu-sheng commented Oct 9, 2021

We don't bother to maintain a separate documentation outside the CLI itself anymore, as a CLI, it's much more straightforward to type swctl help or swctl help dependency than looking up a doc elsewhere.

But these two or more key commands are missing from document.
We could skip the document of all parameters, but we at least should have some for new users.

@kezhenxu94
Copy link
Member Author

We don't bother to maintain a separate documentation outside the CLI itself anymore, as a CLI, it's much more straightforward to type swctl help or swctl help dependency than looking up a doc elsewhere.

But these two or more key commands are missing from document. We could skip the document of all parameters, but we at least should have some for new users.

I don’t mean to delete the doc, I mean the doc should not be hosted elsewhere other than the CLI, all original docs are built into the CLI command and users can type help to look up. I don’t think it a good idea to switch between my terminal and the website to check the manual.

@wu-sheng
Copy link
Member

wu-sheng commented Oct 9, 2021

I am not objecting to read document from terminal. I am saying, we need to tell emd users, use our recommended ways.
I just read the readme, I can't find the guidance.

wankai123
wankai123 previously approved these changes Oct 9, 2021
Copy link
Member

@wankai123 wankai123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature has been fixed.

@wankai123 wankai123 requested a review from wu-sheng October 9, 2021 11:30
@wu-sheng
Copy link
Member

wu-sheng commented Oct 9, 2021

I am good with feature, just have a request about document.

@kezhenxu94 kezhenxu94 merged commit 515a6a4 into master Oct 10, 2021
@kezhenxu94 kezhenxu94 deleted the destServiceID branch October 10, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants