-
Notifications
You must be signed in to change notification settings - Fork 47
Add missing dest-service-id dest-service-name to metrics command
#121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Wait, |
1ab3dd6 to
63fbba6
Compare
wankai123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait..
63fbba6 to
ce8b0ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 29.47% 29.24% -0.24%
==========================================
Files 18 18
Lines 380 383 +3
==========================================
Hits 112 112
- Misses 260 263 +3
Partials 8 8
Continue to review full report at Codecov.
|
c2ff8c7 to
f70d393
Compare
|
You missed the document, please update. |
We don't have document now, they are built in the command |
|
I mean about dependency command, which has the name parameters, right? |
|
We don't bother to maintain a separate documentation outside the CLI itself anymore, as a CLI, it's much more straightforward to type |
f70d393 to
d246f9b
Compare
The command args in the |
d246f9b to
0fb135c
Compare
But these two or more key commands are missing from document. |
I don’t mean to delete the doc, I mean the doc should not be hosted elsewhere other than the CLI, all original docs are built into the CLI command and users can type help to look up. I don’t think it a good idea to switch between my terminal and the website to check the manual. |
|
I am not objecting to read document from terminal. I am saying, we need to tell emd users, use our recommended ways. |
wankai123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature has been fixed.
|
I am good with feature, just have a request about document. |
0fb135c to
ca1b1a9
Compare
ca1b1a9 to
9ce2320
Compare
No description provided.