Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Dec 1, 2023

No description provided.

@mrproliu mrproliu added the enhancement New feature or request label Dec 1, 2023
@mrproliu mrproliu added this to the 0.14.0 milestone Dec 1, 2023
@mrproliu mrproliu requested a review from wu-sheng December 1, 2023 03:16
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4f774f) 26.13% compared to head (6328b32) 26.13%.

❗ Current head 6328b32 differs from pull request most recent head e81a521. Consider uploading reports for the commit e81a521 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   26.13%   26.13%           
=======================================
  Files          22       22           
  Lines         463      463           
=======================================
  Hits          121      121           
  Misses        330      330           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wu-sheng
wu-sheng previously approved these changes Dec 1, 2023
@wu-sheng
Copy link
Member

wu-sheng commented Dec 1, 2023

A nit, as you added layer parameter, you need the version check.

@mrproliu
Copy link
Contributor Author

mrproliu commented Dec 1, 2023

Got it, If the version is smaller than 10.0.0, we should ignore the layer parameter. I will update in this PR.

@wu-sheng wu-sheng merged commit d5f3597 into master Dec 1, 2023
@mrproliu mrproliu deleted the topology-global branch December 1, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants