Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP][SPARK-53327] Test datasketches-memory GH 272#54477

Draft
pan3793 wants to merge 2 commits intoapache:masterfrom
pan3793:SPARK-53327
Draft

[WIP][SPARK-53327] Test datasketches-memory GH 272#54477
pan3793 wants to merge 2 commits intoapache:masterfrom
pan3793:SPARK-53327

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Feb 25, 2026

What changes were proposed in this pull request?

Verify apache/datasketches-memory#272 before releasing, it should solve the below issue

Caused by: java.lang.ExceptionInInitializerError
	at org.apache.datasketches.memory.WritableMemory.writableWrap(WritableMemory.java:333)
	at org.apache.datasketches.memory.WritableMemory.writableWrap(WritableMemory.java:275)
	at org.apache.datasketches.hll.ToByteArrayImpl.toCouponByteArray(ToByteArrayImpl.java:206)
	at org.apache.datasketches.hll.AbstractCoupons.toUpdatableByteArray(AbstractCoupons.java:130)
	at org.apache.datasketches.hll.HllSketch.toUpdatableByteArray(HllSketch.java:466)
	at org.apache.spark.sql.catalyst.expressions.aggregate.HllSketchAgg.serialize(datasketchesAggregates.scala:185)
	...
Caused by: java.lang.IllegalArgumentException: Unsupported JDK Major Version. It must be one of 1.8, 8, 11, 17, 21: 25
	at org.apache.datasketches.memory.internal.ResourceImpl.checkJavaVersion(ResourceImpl.java:155)
	at org.apache.datasketches.memory.internal.ResourceImpl.parseJavaVersion(ResourceImpl.java:391)
	at org.apache.datasketches.memory.internal.ResourceImpl.<clinit>(ResourceImpl.java:87)
	... 26 more (ThriftServerQueryTestSuite.scala:240)

Why are the changes needed?

To enable Java 25 support.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

No.

pan3793
pan3793 commented Mar 3, 2026
View reviewed changes
sql/catalyst/src/main/java/org/apache/datasketches/memory/internal/ResourceImpl.java
* @param p1 The second number group
*/
static void checkJavaVersion(final String jdkVer, final int p0, final int p1 ) {
final boolean ok = ((p0 == 1) && (p1 == 8)) || (p0 == 8) || (p0 == 11) || (p0 == 17 || (p0 == 21) || (p0 == 25));
Copy link
Member Author

@pan3793 pan3793 Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the real change - add 25 to the JDK version allow list

@pan3793 pan3793 mentioned this pull request Mar 3, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pan3793