[SPARK-55800][PYTHON] Remove the unused type check for datetime.date#54581
Open
gaogaotiantian wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-55800][PYTHON] Remove the unused type check for datetime.date#54581gaogaotiantian wants to merge 2 commits intoapache:masterfrom
gaogaotiantian wants to merge 2 commits intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Mar 3, 2026
zhengruifeng
reviewed
Mar 3, 2026
zhengruifeng
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We check if an object is an instance of
datetime.datewhen it could bedatetime.datetime- that's unnecessary and pointless becausedatetime.datetimeis a subclass ofdatetime.date. It's documented in python docs so it's guaranteed.We can also safely convert a
datetime.datetimeobject directly. (We have been doing that for a long time).Why are the changes needed?
Remove unnecessary and misleading logic.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.
Was this patch authored or co-authored using generative AI tooling?
No.