[SPARK-59479][K8S] Remove SecurityManager dependency from KubernetesExecutorBuilder and BasicExecutorFeatureStep - #58768
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
Conversation
…xecutorBuilder and BasicExecutorFeatureStep
SecurityManager dependency from KubernetesExecutorBuilder and BasicExecutorFeatureStep
HyukjinKwon
approved these changes
Sep 13, 2026
Member
Author
|
Thank you always, @HyukjinKwon ! |
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 13, 2026
…esExecutorBuilder` and `BasicExecutorFeatureStep` ### What changes were proposed in this pull request? This PR removes the `SecurityManager` dependency from `KubernetesExecutorBuilder` and `BasicExecutorFeatureStep`: - Add `authSecret` to `KubernetesExecutorConf`. - Resolve auth secret in `BasicExecutorFeatureStep` via `KubernetesExecutorConf.authSecret` instead of `SecurityManager`. - Remove `SecurityManager` parameter from `KubernetesExecutorBuilder.buildFromFeatures` and `BasicExecutorFeatureStep`. - Pass auth secret to `KubernetesConf.createExecutorConf` from pod allocators. ### Why are the changes needed? `KubernetesExecutorBuilder` and `BasicExecutorFeatureStep` only require `SecurityManager` to read `secMgr.getSecretKey()`. Passing the whole `SecurityManager` introduces unnecessary coupling and complicates unit testing. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs with the newly added test cases. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Gemini 3.8 Flash Closes #58768 from dongjoon-hyun/SPARK-59479. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 39e6e82) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes the
SecurityManagerdependency fromKubernetesExecutorBuilderandBasicExecutorFeatureStep:authSecrettoKubernetesExecutorConf.BasicExecutorFeatureStepviaKubernetesExecutorConf.authSecretinstead ofSecurityManager.SecurityManagerparameter fromKubernetesExecutorBuilder.buildFromFeaturesandBasicExecutorFeatureStep.KubernetesConf.createExecutorConffrom pod allocators.Why are the changes needed?
KubernetesExecutorBuilderandBasicExecutorFeatureSteponly requireSecurityManagerto readsecMgr.getSecretKey(). Passing the wholeSecurityManagerintroduces unnecessary coupling and complicates unit testing.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs with the newly added test cases.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Gemini 3.8 Flash