Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(ws/dev-dep): replace Jest with modern Vitest#38308

Open
hainenber wants to merge 9 commits intomasterfrom
feat/migrate-to-vitest-for-superset-websocket
Open

feat(ws/dev-dep): replace Jest with modern Vitest#38308
hainenber wants to merge 9 commits intomasterfrom
feat/migrate-to-vitest-for-superset-websocket

Conversation

@hainenber
Copy link
Contributor

@hainenber hainenber commented Feb 28, 2026

feat(ws/dev-dep): replace Jest with modern Vitest

SUMMARY

Starting point for migrating Superset's FE test framework to ESM-friendly, modern and lightweight Vitest. No changes in the business code beside a few import modifications to keep up with newer type definitions

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Green CI as acceptance criterion.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 28, 2026 •
edited
Loading

Code Review Agent Run #a3e068

Actionable Suggestions - 0
Review Details
  • Files reviewed - 4 · Commit Range: 11d476e..be9a136
    • superset-websocket/jest.config.js
    • superset-websocket/spec/config.test.ts
    • superset-websocket/spec/index.test.ts
    • superset-websocket/src/index.ts
  • Files skipped - 2
    • superset-websocket/package-lock.json - Reason: Filter setting
    • superset-websocket/package.json - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Eslint (Linter) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the frontend:refactor Related to refactoring the frontend label Feb 28, 2026
codeant-ai-for-open-source[bot]
codeant-ai-for-open-source bot reviewed Feb 28, 2026
View reviewed changes
@netlify
Copy link

netlify bot commented Feb 28, 2026

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit be9a136
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69a2aeb19b83430008954060
😎 Deploy Preview https://deploy-preview-38308--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

hainenber and others added 2 commits February 28, 2026 16:07
@hainenber @codeant-ai-for-open-source
Apply suggestions from code review
02fb3c6 
Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>
@hainenber
Merge branch 'master' into feat/migrate-to-vitest-for-superset-websocket
25b3ab7 
Signed-off-by: hainenber <[email protected]>
@netlify
Copy link

netlify bot commented Feb 28, 2026

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 454dff9
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69a2aeee2d93c70008800f72
😎 Deploy Preview https://deploy-preview-38308--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 28, 2026

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 25b3ab7
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69a2b1b217d91900082efc1e
😎 Deploy Preview https://deploy-preview-38308--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 28, 2026

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 081a5dd
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69a2b2dbbd517e000859626d
😎 Deploy Preview https://deploy-preview-38308--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Feb 28, 2026
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 28, 2026 •
edited
Loading

Code Review Agent Run #c21fcf

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: be9a136..a4ea164
    • superset-websocket/spec/index.test.ts
  • Files skipped - 1
    • superset-websocket/package-lock.json - Reason: Filter setting
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@rusackas
Copy link
Member

rusackas commented Mar 2, 2026

I have no problem with this if it's a drop-in replacement, but @msyavuz and @sadpandajoe might have more opinions here than I do :D

@msyavuz
Copy link
Member

msyavuz commented Mar 2, 2026

I like vitest and tried a similar thing in the past but couldn't get it to perform as well as jest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

@sadpandajoe sadpandajoe Awaiting requested review from sadpandajoe sadpandajoe is a code owner

@msyavuz msyavuz Awaiting requested review from msyavuz

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

@justinpark justinpark Awaiting requested review from justinpark

1 more reviewer

@codeant-ai-for-open-source codeant-ai-for-open-source[bot] codeant-ai-for-open-source[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dependencies:npm frontend:refactor Related to refactoring the frontend github_actions Pull requests that update GitHub Actions code size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hainenber @rusackas @msyavuz