Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: remove redundant service-worker.js placeholder#38348

Open
villebro wants to merge 1 commit intoapache:masterfrom
villebro:villebro/service-worker
Open

chore: remove redundant service-worker.js placeholder#38348
villebro wants to merge 1 commit intoapache:masterfrom
villebro:villebro/service-worker

Conversation

@villebro
Copy link
Member

@villebro villebro commented Mar 2, 2026 •
edited
Loading

SUMMARY

A recent PR #36191 introduced a new file in the /superset/static path that gets overwritten every time you run npm run build. This file is redundant, as it will get rebuilt everytime you rebuild the frontend assets, and is problematic, as the rebuilt asset may accidentally get committed upstream. A workaround was merged in #38106 which avoids the rebuild on npm run dev-server, but still remains in the npm run build workflow. This PR does the following:

  • Removes the /superset/static/service-worker.js file from the git tree
  • Reverts the changes from fix(webpack): skip building service worker in dev #38106 (no longer needed)
  • Updates .gitignore to ignore the contents of /superset/static (version_info.json was already being ignored - now we ignore the entire directory's contents)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Wipe out static assets
  2. Run npm run build
  3. Start flask server and see that the service-worker.js file is indeed there after the change

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Mar 2, 2026 •
edited
Loading

Code Review Agent Run #a685b8

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 9127daa..9127daa
    • superset-frontend/webpack.config.js
    • superset/static/service-worker.js
  • Files skipped - 1
    • .gitignore - Reason: Filter setting
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@netlify
Copy link

netlify bot commented Mar 2, 2026

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 9127daa
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69a5e172a26dc40008276018
😎 Deploy Preview https://deploy-preview-38348--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Mar 2, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.87%. Comparing base (bb6ee9e) to head (9127daa).
⚠️ Report is 35 commits behind head on master.

❌ Your project check has failed because the head coverage (96.03%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #38348      +/-   ##
==========================================
+ Coverage   64.11%   64.87%   +0.76%     
==========================================
  Files        1810     2483     +673     
  Lines       71175   123024   +51849     
  Branches    22650    28523    +5873     
==========================================
+ Hits        45631    79817   +34186     
- Misses      25544    41810   +16266     
- Partials        0     1397    +1397
Flag Coverage Δ
hive 41.11% <ø> (?)
javascript 64.11% <ø> (ø)
mysql 64.05% <ø> (?)
postgres 64.13% <ø> (?)
presto 41.13% <ø> (?)
python 65.90% <ø> (?)
sqlite 63.72% <ø> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msyavuz msyavuz Awaiting requested review from msyavuz

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

@rusackas rusackas Awaiting requested review from rusackas

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@villebro