Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(templates): restore css_bundle calls in spa.html for production builds#38350

Open
gabotorresruiz wants to merge 1 commit intoapache:masterfrom
gabotorresruiz:fix/inter-font-not-loading
Open

fix(templates): restore css_bundle calls in spa.html for production builds#38350
gabotorresruiz wants to merge 1 commit intoapache:masterfrom
gabotorresruiz:fix/inter-font-not-loading

Conversation

@gabotorresruiz
Copy link
Contributor

@gabotorresruiz gabotorresruiz commented Mar 3, 2026

SUMMARY

Restores css_bundle() calls in spa.html that were accidentally dropped during the Ant Design v5 overhaul. Without them, webpack-extracted CSS files (including @font-face declarations for Inter) are never loaded via <link> tags in production builds, causing the browser to fall back to Helvetica.

Dev mode was unaffected since style-loader injects CSS inline.

TESTING INSTRUCTIONS

  1. Reproduce the bug with the pre-built 6.0.0 image. Run:
TAG=6.0.0 docker compose -f docker-compose-image-tag.yml up
  1. Open http://localhost:8088, inspect any text in DevTools --> "Rendered Fonts" shows Helvetica
  2. Stop the container.
  3. Test the fix by mounting the updated template. Create a docker-compose.override.yml file in the repository root
services:
  superset:
    volumes:
      - ./superset/templates:/app/superset/templates
  1. Then run:
TAG=6.0.0 docker compose -f docker-compose-image-tag.yml -f docker-compose.override.yml up
  1. Finally, open http://localhost:8088, inspect any text --> "Rendered Fonts" now shows Inter

ADDITIONAL INFORMATION

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Mar 3, 2026 •
edited
Loading

Code Review Agent Run #e0dff2

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 13ed9a2..13ed9a2
    • superset/templates/superset/spa.html
    • tests/unit_tests/extension_tests.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Mar 3, 2026
@gabotorresruiz gabotorresruiz mentioned this pull request Mar 3, 2026
Open
@netlify
Copy link

netlify bot commented Mar 3, 2026 •
edited
Loading

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit af92e61
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69a651929d3f450008186da2
😎 Deploy Preview https://deploy-preview-38350--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Mar 3, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.98%. Comparing base (3e10ab7) to head (af92e61).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #38350      +/-   ##
==========================================
+ Coverage   64.28%   64.98%   +0.69%     
==========================================
  Files        1810     2483     +673     
  Lines       71479   123326   +51847     
  Branches    22770    28642    +5872     
==========================================
+ Hits        45953    80138   +34185     
- Misses      25526    41791   +16265     
- Partials        0     1397    +1397
Flag Coverage Δ
hive 41.11% <ø> (?)
mysql 64.05% <ø> (?)
postgres 64.13% <ø> (?)
presto 41.13% <ø> (?)
python 65.90% <ø> (?)
sqlite 63.72% <ø> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabotorresruiz gabotorresruiz force-pushed the fix/inter-font-not-loading branch from 13ed9a2 to af92e61 Compare March 3, 2026 03:12
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Mar 3, 2026 •
edited
Loading

Code Review Agent Run #22dc76

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: af92e61..af92e61
    • superset/templates/superset/spa.html
    • tests/unit_tests/extension_tests.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

change:frontend Requires changing the frontend size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inter not loading/rendering in Superset version 6.0.0 causing the web app to use a fallback font

1 participant

@gabotorresruiz