Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for boringssl #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for boringssl #3055

wants to merge 2 commits into from

Conversation

layus
Copy link
Contributor

@layus layus commented Oct 24, 2024

This adds support for boringssl where OPENSSL_thread_stop is not implemented/defined and CONF_modules_unload is also missing. Fixed by removing these calls when boringssl is in use.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@jeking3
Copy link
Contributor

jeking3 commented Oct 24, 2024

You'll want to align this to #3049 which I just merged.

@layus
Copy link
Contributor Author

layus commented Oct 24, 2024 via email

@Jens-G Jens-G added the c++ label Oct 24, 2024
@layus
Copy link
Contributor Author

layus commented Nov 5, 2024

@jeking3 Resolved conflicts with #3049, and fixed the logic as per my comment above. May I ask you to have a second look at this PR ?

jeking3
jeking3 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that up.

@Jens-G Jens-G added the rebase needed rebase needed label Nov 17, 2024
@seanngpack
Copy link

any movement on this? would be great to have this change in

@Dev-iL Dev-iL mentioned this pull request Aug 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeking3 jeking3 jeking3 approved these changes

Assignees
No one assigned
Labels
c++ rebase needed rebase needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@layus @jeking3 @seanngpack @Jens-G