This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Correcting use of httpsPort instead of secure.port #6538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying to change the TrafficRouter SecurePort value to other than 443, and tried to use the parameter secure.port added to the server.xml on the CCR profile in Traffic Portal. But noticed, that TcOps/TcMon, do not add that parameter to the CrCronfig.json.I digged into the code and fount that the use of secure.port was added to TrafficRouter on the following commit: apache@8ff9006 However, no counter part was added to TcOps to actually state the value secure.port from the TrafficPortal paramenters. The value that TcOps adds to the CrConfig.json is the httpsPort, from the server configuration itself on TrafficPortal, but that parameter is not used anyowhere by Traffic Router (from what I saw).I see that it would require just two lines edits on traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/util/LanguidState.java to make use of httpsPort and not the unexisting secure.port.Basically, edit lines 86 and 87 of the file, and replace secure.port for httpsPort
rawlinp
suggested changes
Feb 7, 2022
...ter/core/src/main/java/org/apache/traffic_control/traffic_router/core/util/LanguidState.java
Outdated
Show resolved
Hide resolved
Contributor
|
Also, I just want to point out that if you use a non-standard |
rawlinp
approved these changes
Feb 10, 2022
Contributor
rawlinp
left a comment
There was a problem hiding this comment.
This looks good, but there are merge conflicts to resolve (most likely in CHANGELOG.md).
rawlinp
approved these changes
Feb 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to change the TrafficRouter SecurePort value to other than 443, and tried to use the parameter secure.port added to the server.xml on the CCR profile in Traffic Portal. But noticed, that TcOps/TcMon, do not add that parameter to the CrCronfig.json.
I digged into the code and fount that the use of secure.port was added to TrafficRouter on the following commit: 8ff9006 However, no counter part was added to TcOps to actually state the value secure.port from the TrafficPortal paramenters. The value that TcOps adds to the CrConfig.json is the httpsPort, from the server configuration itself on TrafficPortal, but that parameter is not used anywhere by Traffic Router (from what I saw).
I see that it would require just two lines edits on traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/util/LanguidState.java to make use of httpsPort and not the unexisting secure.port.
Basically, edit lines 86 and 87 of the file, and replace secure.port for httpsPort
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Try adding the secure.port parameter to the CCR profile on Traffic Portal. It does not matter if you add it to server.xml or CrConfig,json, Traffic Ops never assigns secure.port to the traffic routers under that profile. Applying the change on the file on this PR, makes TR use the httpsPort configured under the server configuration un Traffic Portal.
If this is a bugfix, which Traffic Control versions contained the bug?
All
PR submission checklist